github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 20:43:19 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: make sidebar title static (#25040)

Browse Source 
* UX: make sidebar title static

* tests
This commit is contained in:
chapoi 2023-12-26 14:37:32 +02:00 committed by GitHub
parent 3a20718526
commit 32c438387b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/app/widgets/sidebar-toggle.js
View File

@ -7,9 +7,7 @@ export default createWidget("sidebar-toggle", {
const attrs = this.attrs; const attrs = this.attrs;
return [ return [
this.attach("button", { this.attach("button", {
title: attrs.showSidebar title: "sidebar.title",
? "sidebar.hide_sidebar"
: "sidebar.show_sidebar",
icon: "bars", icon: "bars",
action: this.site.narrowDesktopView action: this.site.narrowDesktopView
? "toggleHamburger" ? "toggleHamburger"

4
app/assets/javascripts/discourse/tests/acceptance/sidebar-user-test.js
View File

@ -218,7 +218,7 @@ acceptance(
assert.strictEqual( assert.strictEqual(
query(".btn-sidebar-toggle").title, query(".btn-sidebar-toggle").title,
I18n.t("sidebar.hide_sidebar"), I18n.t("sidebar.title"),
"has the right title attribute when sidebar is expanded" "has the right title attribute when sidebar is expanded"
); );
@ -233,7 +233,7 @@ acceptance(
assert.strictEqual( assert.strictEqual(
query(".btn-sidebar-toggle").title, query(".btn-sidebar-toggle").title,
I18n.t("sidebar.show_sidebar"), I18n.t("sidebar.title"),
"has the right title attribute when sidebar is collapsed" "has the right title attribute when sidebar is collapsed"
); );
}); });

3
config/locales/client.en.yml
View File

@ -4475,8 +4475,7 @@ en:
redirect_after_success: "Second factor authentication is successful. Redirecting to the previous page…" redirect_after_success: "Second factor authentication is successful. Redirecting to the previous page…"
sidebar: sidebar:
show_sidebar: "Show sidebar" title: "Sidebar"
hide_sidebar: "Hide sidebar"
unread_count: unread_count:
one: "%{count} unread" one: "%{count} unread"
other: "%{count} unread" other: "%{count} unread"