github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-17 08:52:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix Discourse.Utilities.avatarImg test on Fx.

Browse Source 
This qUnit test was failing in Firefox 36 with "setting a property that has only a getter" because devicePixelRatio was being changed directly. The fix uses defineProperty to redefine devicePixelRatio instead.
This commit is contained in:
Ben Hadley-Evans 2015-03-20 12:53:56 +00:00
parent 18f4f60956
commit 38fbbb28e3
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/javascripts/lib/utilities-test.js.es6
View File

@ -123,9 +123,17 @@ test("avatarUrl", function() {
equal(utils.avatarUrl('/fake/template/{size}.png', 'large'), "/fake/template/" + rawSize(45) + ".png", "different size");
});
var setDevicePixelRatio = function(value) {
if(Object.defineProperty) {
Object.defineProperty(window, "devicePixelRatio", { value: 2 })
} else {
window.devicePixelRatio = value;
}
};
test("avatarImg", function() {
var oldRatio = window.devicePixelRatio;
window.devicePixelRatio = 2;
setDevicePixelRatio(2);
var avatarTemplate = "/path/to/avatar/{size}.png";
equal(utils.avatarImg({avatarTemplate: avatarTemplate, size: 'tiny'}),
@ -143,7 +151,7 @@ test("avatarImg", function() {
blank(utils.avatarImg({avatarTemplate: "", size: 'tiny'}),
"it doesn't render avatars for invalid avatar template");
window.devicePixelRatio = oldRatio;
setDevicePixelRatio(oldRatio);
});
test("allowsAttachments", function() {