github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-19 06:52:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Sum pageviews with number instead of string (#28596)

Browse Source 
When the tooltip items are tooltipItem = [{parsed: {y:12} }, {parsed: {y:10} } ], reducing without a initial value as a number would result in Javascript thinking it is a string. Thanks, Javascript!

There are no tests here yet since this makes use of an external library Chart.js.
This commit is contained in:
Natalie Tay 2024-08-28 19:24:57 +08:00 committed by GitHub
parent 480f26a2c2
commit 3a04443632
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/admin/addon/components/admin-report-stacked-chart.gjs
View File

@ -42,7 +42,8 @@ export default class AdminReportStackedChart extends Component {
callbacks: {
beforeFooter: (tooltipItem) => {
const total = tooltipItem.reduce(
(sum, item) => sum + parseInt(item.parsed.y || 0, 10)
(sum, item) => sum + parseInt(item.parsed.y || 0, 10),
0
);
return `= ${total}`;
},