From 3c26df78ea612f0a963853400633d75c096cace2 Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Wed, 18 Oct 2023 11:33:35 +0800 Subject: [PATCH] UX: Fix deselect text location in edit sidebar category/tag modal (#23966) Why this change? In 38d32080274a864580c86827e98ab1de914269a5, the position of the `headerBelowTitle` outlet was changed causing the deselect text in the edit sidebar catgegory/tag modals to appear inline with the title which we do not want. What does this change do? This change introduces the `belowModalTitle` outlet in `DModal` which is where the `headerBelowTitle` outlet was located before it was changed. --- app/assets/javascripts/discourse/app/components/d-modal.hbs | 2 ++ .../app/components/sidebar/edit-navigation-menu/modal.hbs | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse/app/components/d-modal.hbs b/app/assets/javascripts/discourse/app/components/d-modal.hbs index 39fafe75dc2..3bb2285b186 100644 --- a/app/assets/javascripts/discourse/app/components/d-modal.hbs +++ b/app/assets/javascripts/discourse/app/components/d-modal.hbs @@ -56,6 +56,8 @@ {{/if}} {{/if}} + + {{yield to="belowModalTitle"}} {{yield to="headerBelowTitle"}} diff --git a/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/modal.hbs b/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/modal.hbs index a29a52c6560..b38354c9e60 100644 --- a/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/modal.hbs +++ b/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/modal.hbs @@ -3,7 +3,7 @@ @title={{i18n @title}} @closeModal={{@closeModal}} > - <:headerBelowTitle> + <:belowModalTitle>