github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 15:25:35 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: improve featured link positioning in topic titles (#25427)

Browse Source
This commit is contained in:
Kris 2024-01-25 16:49:34 -05:00 committed by GitHub
parent d022b85a52
commit 3c54d9e64c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 8 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/tests/acceptance/topic-test.js
View File

@ -285,7 +285,7 @@ acceptance("Topic featured links", function (needs) {
await visit("/t/-/299/1");
const link = query(".title-wrapper .topic-featured-link");
assert.strictEqual(link.innerText, " example.com");
assert.strictEqual(link.innerText, "example.com");
assert.strictEqual(link.getAttribute("rel"), "ugc");
});

5
app/assets/stylesheets/common/base/_topic-list.scss
View File

@ -148,6 +148,7 @@
padding: 15px 0;
word-break: break-word;
color: var(--primary);
margin-right: 0.5em;
}
.anon & {
@ -293,10 +294,6 @@
}
}
.topic-featured-link {
padding-left: 5px;
}
.topic-excerpt {
display: block;
font-size: var(--font-down-1);

1
app/assets/stylesheets/common/base/header.scss
View File

@ -338,6 +338,7 @@
display: inline-flex;
align-items: center;
max-width: 100%;
gap: 0.5em;
.discourse-tags {
display: inline;
color: var(--header_primary-high);

5
app/assets/stylesheets/common/base/tagging.scss
View File

@ -43,6 +43,7 @@
.topic-header-extra {
display: inline-flex;
align-items: center;
gap: 0.5em;
}
.badge-wrapper {
@ -128,9 +129,6 @@
.discourse-tags {
font-size: var(--font-down-1);
}
.discourse-tags + .topic-featured-link {
margin-left: 0.5em;
}
}
.discourse-tags {
@ -155,7 +153,6 @@ header .discourse-tag {
.list-tags {
display: inline-block;
margin-right: 3px;
font-size: var(--font-down-1);
}

12
app/assets/stylesheets/common/base/topic.scss
View File

@ -267,9 +267,6 @@ $topic-progress-height: 42px;
button {
margin: 0 0.5em 0 0;
}
a.topic-featured-link {
display: inline-block;
}
.topic-statuses {
line-height: 1.2;
.d-icon {
@ -287,9 +284,6 @@ $topic-progress-height: 42px;
display: flex;
flex-wrap: wrap;
width: 90%;
a.topic-featured-link {
display: inline-block;
}
}
h1 {
margin-bottom: 0;
@ -435,12 +429,14 @@ $topic-progress-height: 42px;
}
a.topic-featured-link {
display: inline-block;
display: inline-flex;
align-items: center;
text-transform: lowercase;
color: var(--primary-med-or-secondary-med);
font-size: 0.875rem;
.d-icon {
margin-right: 3px;
font-size: var(--font-down-1);
margin-right: 0.25em;
}
}

4
app/assets/stylesheets/desktop/category-list.scss
View File

@ -142,10 +142,6 @@
}
}
.topic-featured-link {
padding-left: 8px;
}
.subcategories-with-subcategories {
.category-description {
display: none;