github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-22 00:03:26 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

REFACTOR: removes useless variable assignment (#9666)

Browse Source
This commit is contained in:
Joffrey JAFFEUX 2020-05-07 16:41:26 +02:00 committed by GitHub
parent 1dd9df9cd0
commit 3cd412ae02
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/assets/javascripts/select-kit/components/select-kit.js
View File

@ -641,19 +641,18 @@ export default Component.extend(
}, },
_highlightNext() { _highlightNext() {
const highlightedIndex = this.mainCollection.indexOf( let highlightedIndex = this.mainCollection.indexOf(
this.selectKit.highlighted this.selectKit.highlighted
); );
let newHighlightedIndex = highlightedIndex;
const count = this.mainCollection.length; const count = this.mainCollection.length;
if (highlightedIndex < count - 1) { if (highlightedIndex < count - 1) {
newHighlightedIndex = highlightedIndex + 1; highlightedIndex = highlightedIndex + 1;
} else { } else {
newHighlightedIndex = 0; highlightedIndex = 0;
} }
const highlighted = this.mainCollection.objectAt(newHighlightedIndex); const highlighted = this.mainCollection.objectAt(highlightedIndex);
if (highlighted) { if (highlighted) {
this._scrollToRow(highlighted); this._scrollToRow(highlighted);
this.set("selectKit.highlighted", highlighted); this.set("selectKit.highlighted", highlighted);
@ -661,19 +660,18 @@ export default Component.extend(
}, },
_highlightPrevious() { _highlightPrevious() {
const highlightedIndex = this.mainCollection.indexOf( let highlightedIndex = this.mainCollection.indexOf(
this.selectKit.highlighted this.selectKit.highlighted
); );
let newHighlightedIndex = highlightedIndex;
const count = this.mainCollection.length; const count = this.mainCollection.length;
if (highlightedIndex > 0) { if (highlightedIndex > 0) {
newHighlightedIndex = highlightedIndex - 1; highlightedIndex = highlightedIndex - 1;
} else { } else {
newHighlightedIndex = count - 1; highlightedIndex = count - 1;
} }
const highlighted = this.mainCollection.objectAt(newHighlightedIndex); const highlighted = this.mainCollection.objectAt(highlightedIndex);
if (highlighted) { if (highlighted) {
this._scrollToRow(highlighted); this._scrollToRow(highlighted);
this.set("selectKit.highlighted", highlighted); this.set("selectKit.highlighted", highlighted);