diff --git a/app/assets/javascripts/discourse/templates/preferences-email.hbs b/app/assets/javascripts/discourse/templates/preferences-email.hbs index 9adfc3bf581..19a5b128c2a 100644 --- a/app/assets/javascripts/discourse/templates/preferences-email.hbs +++ b/app/assets/javascripts/discourse/templates/preferences-email.hbs @@ -1,4 +1,4 @@ -
+
@@ -9,20 +9,22 @@ {{#if success}}
-
-

- {{#if model.staff}} - {{i18n 'user.change_email.success_staff'}} - {{else}} - {{i18n 'user.change_email.success'}} - {{/if}} -

+
+
+

+ {{#if model.staff}} + {{i18n 'user.change_email.success_staff'}} + {{else}} + {{i18n 'user.change_email.success'}} + {{/if}} +

+
{{else}} {{#if error}}
-
+
{{errorMessage}}
@@ -34,12 +36,14 @@ {{text-field value=newEmail id="change-email" classNames="input-xxlarge" autofocus="autofocus"}} {{input-tip validation=emailValidation}}
-
- {{#if taken}} - {{i18n 'user.change_email.taken'}} - {{else}} - {{i18n 'user.email.instructions'}} - {{/if}} +
+
+ {{#if taken}} + {{i18n 'user.change_email.taken'}} + {{else}} + {{i18n 'user.email.instructions'}} + {{/if}} +
diff --git a/app/assets/javascripts/discourse/templates/preferences-second-factor-backup.hbs b/app/assets/javascripts/discourse/templates/preferences-second-factor-backup.hbs index a81f2c2b9c8..8b49faa123c 100644 --- a/app/assets/javascripts/discourse/templates/preferences-second-factor-backup.hbs +++ b/app/assets/javascripts/discourse/templates/preferences-second-factor-backup.hbs @@ -1,61 +1,74 @@ -
+
-

{{i18n "user.second_factor_backup.title"}}

- {{#if successMessage}} -
- {{successMessage}} +
+
+

{{i18n "user.second_factor_backup.title"}}

- {{/if}} +
+ {{#if successMessage}} +
+ {{successMessage}} +
+ {{/if}} - {{#if errorMessage}} -
- {{errorMessage}} -
- {{/if}} - -
- {{second-factor-input - value=secondFactorToken - maxlength=6 - inputId="second-factor-token"}} - -
- {{d-button - action="generateSecondFactorCodes" - class="btn btn-primary" - disabled=isDisabledGenerateBackupCodeBtn - label=generateBackupCodeBtnLabel}} - {{#if backupEnabled}} - {{d-button - action="disableSecondFactorBackup" - class="btn btn-danger" - disabled=isDisabledDisableBackupCodeBtn - label="user.second_factor_backup.disable"}} + {{#if errorMessage}} +
+ {{errorMessage}} +
{{/if}}
-
- {{i18n "user.second_factor.disable_description"}} + +
+
+ {{second-factor-input + value=secondFactorToken + maxlength=6 + inputId="second-factor-token"}} + +
+ {{i18n "user.second_factor.disable_description"}} +
+
- {{#conditional-loading-section isLoading=loading}} - {{#if backupCodes}} -

{{i18n "user.second_factor_backup.codes.title"}}

+
+
+
+ {{d-button + action="generateSecondFactorCodes" + class="btn btn-primary" + disabled=isDisabledGenerateBackupCodeBtn + label=generateBackupCodeBtnLabel}} + {{#if backupEnabled}} + {{d-button + action="disableSecondFactorBackup" + class="btn btn-danger" + disabled=isDisabledDisableBackupCodeBtn + label="user.second_factor_backup.disable"}} + {{/if}} +
-

- {{i18n "user.second_factor_backup.codes.description"}} -

+ {{#conditional-loading-section isLoading=loading}} + {{#if backupCodes}} +

{{i18n "user.second_factor_backup.codes.title"}}

- {{backup-codes - copyBackupCode=(action "copyBackupCode") - backupCodes=backupCodes}} - {{/if}} - {{/conditional-loading-section}} +

+ {{i18n "user.second_factor_backup.codes.description"}} +

- {{#link-to "preferences.account" model.username}} - {{i18n "go_back"}} - {{/link-to}} + {{backup-codes + copyBackupCode=(action "copyBackupCode") + backupCodes=backupCodes}} + + {{#link-to "preferences.account" model.username}} + {{i18n "go_back"}} + {{/link-to}} + {{/if}} + {{/conditional-loading-section}} +
+
diff --git a/app/assets/javascripts/discourse/templates/preferences-second-factor.hbs b/app/assets/javascripts/discourse/templates/preferences-second-factor.hbs index 6621b7e2a7a..c425d6bf7f7 100644 --- a/app/assets/javascripts/discourse/templates/preferences-second-factor.hbs +++ b/app/assets/javascripts/discourse/templates/preferences-second-factor.hbs @@ -1,5 +1,6 @@ -
+
+

{{i18n 'user.second_factor.title'}}

@@ -8,7 +9,7 @@ {{#if errorMessage}}
-
+
{{errorMessage}}
@@ -22,7 +23,7 @@ {{second-factor-input value=secondFactorToken inputId='second-factor-token'}}
-
+
{{i18n 'user.second_factor.disable_description'}}
@@ -97,7 +98,7 @@ autofocus="autofocus"}}
-
+
{{i18n 'user.second_factor.confirm_password_description'}}
diff --git a/app/assets/javascripts/discourse/templates/preferences-username.hbs b/app/assets/javascripts/discourse/templates/preferences-username.hbs index fc68eccedc8..c0ab8faee8f 100644 --- a/app/assets/javascripts/discourse/templates/preferences-username.hbs +++ b/app/assets/javascripts/discourse/templates/preferences-username.hbs @@ -1,4 +1,4 @@ -
+
@@ -14,10 +14,10 @@

- {{#if taken}} - {{i18n 'user.change_username.taken'}} - {{/if}} - {{errorMessage}} + {{#if taken}} + {{i18n 'user.change_username.taken'}} + {{/if}} + {{errorMessage}}

diff --git a/app/assets/stylesheets/common/base/user.scss b/app/assets/stylesheets/common/base/user.scss index 13438d40596..6170668509c 100644 --- a/app/assets/stylesheets/common/base/user.scss +++ b/app/assets/stylesheets/common/base/user.scss @@ -563,11 +563,6 @@ margin-right: 10px; } - .second-factor-form { - display: flex; - align-items: center; - } - .form-horizontal .instructions { margin-left: 0; } diff --git a/app/assets/stylesheets/desktop/user.scss b/app/assets/stylesheets/desktop/user.scss index fb988b512e6..e423ee58c4d 100644 --- a/app/assets/stylesheets/desktop/user.scss +++ b/app/assets/stylesheets/desktop/user.scss @@ -292,10 +292,6 @@ margin-top: 0; } - .form-horizontal .instructions { - margin-left: 8px; - } - .pref-mailing-list-mode .controls { select { width: 400px; diff --git a/test/javascripts/acceptance/preferences-test.js.es6 b/test/javascripts/acceptance/preferences-test.js.es6 index a6e33e1b3d6..b70b13a061f 100644 --- a/test/javascripts/acceptance/preferences-test.js.es6 +++ b/test/javascripts/acceptance/preferences-test.js.es6 @@ -125,7 +125,7 @@ QUnit.test("second factor", assert => { }); fillIn("#password", "secrets"); - click(".user-content .btn-primary"); + click(".user-preferences .btn-primary"); andThen(() => { assert.ok(exists("#test-qr"), "shows qr code"); @@ -156,7 +156,7 @@ QUnit.test("second factor backup", assert => { }); fillIn("#second-factor-token", "111111"); - click(".second-factor-form .btn-primary"); + click(".user-preferences .btn-primary"); andThen(() => { assert.ok(exists(".backup-codes-area"), "shows backup codes");