github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-28 00:54:21 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Remove up/down key bindings for search results

Browse Source 
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
This commit is contained in:
cpradio 2014-08-28 19:58:07 -04:00
parent 1acb2a13f1
commit 3e7084743c
1 changed files with 23 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
app/assets/javascripts/discourse/views/search.js.es6
View File

@ -2,28 +2,28 @@ export default Discourse.View.extend({
tagName: 'div',
classNames: ['d-dropdown'],
elementId: 'search-dropdown',
templateName: 'search',
templateName: 'search'
didInsertElement: function() {
// Delegate ESC to the composer
var controller = this.get('controller');
return $('body').on('keydown.search', function(e) {
if ($('#search-dropdown').is(':visible')) {
switch (e.which) {
case 13:
controller.select();
e.preventDefault();
break;
case 38:
controller.moveUp();
e.preventDefault();
break;
case 40:
controller.moveDown();
e.preventDefault();
break;
}
}
});
}
// didInsertElement: function() {
// // Delegate ESC to the composer
// var controller = this.get('controller');
// return $('body').on('keydown.search', function(e) {
// if ($('#search-dropdown').is(':visible')) {
// switch (e.which) {
// case 13:
// controller.select();
// e.preventDefault();
// break;
// case 38:
// controller.moveUp();
// e.preventDefault();
// break;
// case 40:
// controller.moveDown();
// e.preventDefault();
// break;
// }
// }
// });
// }
});