From 42117c684fa2c1b47e544c13d374bb0ced8dd8ac Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Tue, 28 Jan 2014 16:29:04 -0500 Subject: [PATCH] Remove `console` from .jshintrc. If we need our app to log, use `Ember.Logger` instead. --- .jshintrc | 3 +-- app/assets/javascripts/discourse/mixins/ajax.js | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.jshintrc b/.jshintrc index 3caecd3fb96..cdf881c4410 100644 --- a/.jshintrc +++ b/.jshintrc @@ -29,7 +29,6 @@ "moment", "start", "_", - "console", "alert", "controllerFor", "testController", @@ -66,4 +65,4 @@ "eqnull": true, "quotmark": false, "lastsemic": true -} \ No newline at end of file +} diff --git a/app/assets/javascripts/discourse/mixins/ajax.js b/app/assets/javascripts/discourse/mixins/ajax.js index 913cbed1a12..4fbc4b0bd69 100644 --- a/app/assets/javascripts/discourse/mixins/ajax.js +++ b/app/assets/javascripts/discourse/mixins/ajax.js @@ -34,10 +34,10 @@ Discourse.Ajax = Em.Mixin.create({ } if (args.success) { - console.warning("DEPRECATION: Discourse.ajax should use promises, received 'success' callback"); + Ember.Logger.error("DEPRECATION: Discourse.ajax should use promises, received 'success' callback"); } if (args.error) { - console.warning("DEPRECATION: Discourse.ajax should use promises, received 'error' callback"); + Ember.Logger.error("DEPRECATION: Discourse.ajax should use promises, received 'error' callback"); } // If we have URL_FIXTURES, load from there instead (testing)