DEV: Upgrading Discourse to Zeitwerk (#8098)

Zeitwerk simplifies working with dependencies in dev and makes it easier reloading class chains. 

We no longer need to use Rails "require_dependency" anywhere and instead can just use standard 
Ruby patterns to require files.

This is a far reaching change and we expect some followups here.

app/controllers/about_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'rate_limiter'
-
 class AboutController < ApplicationController
 
   requires_login only: [:live_post_counts]

app/controllers/admin/backups_controller.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "backup_restore/backup_restore"
+require "backup_restore"
 require "backup_restore/backup_store"
 
 class Admin::BackupsController < Admin::AdminController

app/controllers/admin/email_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'email/renderer'
-
 class Admin::EmailController < Admin::AdminController
 
   def index

app/controllers/admin/embedding_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'embedding'
-
 class Admin::EmbeddingController < Admin::AdminController
 
   before_action :fetch_embedding

app/controllers/admin/emojis_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'upload_creator'
-
 class Admin::EmojisController < Admin::AdminController
 
   def index

app/controllers/admin/reports_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'report'
-
 class Admin::ReportsController < Admin::AdminController
   def index
     reports_methods = ['page_view_total_reqs'] +

app/controllers/admin/screened_ip_addresses_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'ip_addr'
-
 class Admin::ScreenedIpAddressesController < Admin::AdminController
 
   before_action :fetch_screened_ip_address, only: [:update, :destroy]

app/controllers/admin/site_texts_controller.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'seed_data/categories'
-require_dependency 'seed_data/topics'
-
 class Admin::SiteTextsController < Admin::AdminController
 
   def self.preferred_keys

app/controllers/admin/staff_action_logs_controller.rb

@@ -26,8 +26,6 @@ class Admin::StaffActionLogsController < Admin::AdminController
   end
 
   def diff
-    require_dependency "discourse_diff"
-
     @history = UserHistory.find(params[:id])
     prev = @history.previous_value
     cur = @history.new_value

app/controllers/admin/themes_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'upload_creator'
-require_dependency 'theme_store/tgz_exporter'
 require 'base64'
 
 class Admin::ThemesController < Admin::AdminController

app/controllers/admin/users_controller.rb

@@ -1,9 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'user_destroyer'
-require_dependency 'admin_user_index_query'
-require_dependency 'admin_confirmation'
-
 class Admin::UsersController < Admin::AdminController
 
   before_action :fetch_user, only: [:suspend,

app/controllers/admin/versions_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'discourse_updates'
-
 class Admin::VersionsController < Admin::AdminController
   def show
     render json: DiscourseUpdates.check_version

app/controllers/application_controller.rb

@@ -1,20 +1,6 @@
 # frozen_string_literal: true
 
 require 'current_user'
-require_dependency 'canonical_url'
-require_dependency 'discourse'
-require_dependency 'custom_renderer'
-require_dependency 'archetype'
-require_dependency 'rate_limiter'
-require_dependency 'crawler_detection'
-require_dependency 'json_error'
-require_dependency 'letter_avatar'
-require_dependency 'distributed_cache'
-require_dependency 'global_path'
-require_dependency 'secure_session'
-require_dependency 'topic_query'
-require_dependency 'hijack'
-require_dependency 'read_only_header'
 
 class ApplicationController < ActionController::Base
   include CurrentUser

app/controllers/categories_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'category_serializer'
-
 class CategoriesController < ApplicationController
 
   requires_login except: [:index, :categories_and_latest, :categories_and_top, :show, :redirect, :find_by_slug]

app/controllers/composer_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'html_to_markdown'
-
 class ComposerController < ApplicationController
 
   requires_login

app/controllers/composer_messages_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'composer_messages_finder'
-
 class ComposerMessagesController < ApplicationController
 
   requires_login

app/controllers/embed_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'topic_query_params'
-
 class EmbedController < ApplicationController
   include TopicQueryParams
 

app/controllers/inline_onebox_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'inline_oneboxer'
-
 class InlineOneboxController < ApplicationController
   requires_login
 

app/controllers/invites_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'rate_limiter'
-
 class InvitesController < ApplicationController
 
   requires_login only: [

app/controllers/list_controller.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'topic_list_responder'
-require_dependency 'topic_query_params'
-
 class ListController < ApplicationController
   include TopicListResponder
   include TopicQueryParams

app/controllers/notifications_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'notification_serializer'
-
 class NotificationsController < ApplicationController
 
   requires_login

app/controllers/onebox_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'oneboxer'
-
 class OneboxController < ApplicationController
   requires_login
 

app/controllers/post_action_users_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'discourse'
-
 class PostActionUsersController < ApplicationController
   def index
     params.require(:post_action_type_id)

app/controllers/post_actions_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'discourse'
-
 class PostActionsController < ApplicationController
   requires_login
 

app/controllers/posts_controller.rb

@@ -1,14 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'new_post_manager'
-require_dependency 'post_creator'
-require_dependency 'post_action_destroyer'
-require_dependency 'post_destroyer'
-require_dependency 'post_merger'
-require_dependency 'distributed_memoizer'
-require_dependency 'new_post_result_serializer'
-require_dependency 'post_locker'
-
 class PostsController < ApplicationController
 
   requires_login except: [

app/controllers/reviewables_controller.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-require_dependency 'reviewable_explanation_serializer'
 
 class ReviewablesController < ApplicationController
   requires_login

app/controllers/search_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'search'
-
 class SearchController < ApplicationController
 
   skip_before_action :check_xhr, only: :show

app/controllers/session_controller.rb

@@ -1,11 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'rate_limiter'
-require_dependency 'single_sign_on'
-require_dependency 'single_sign_on_provider'
-require_dependency 'url_helper'
-require_dependency 'webauthn/webauthn'
-
 class SessionController < ApplicationController
   class LocalLoginNotAllowed < StandardError; end
   rescue_from LocalLoginNotAllowed do

app/controllers/similar_topics_controller.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'similar_topic_serializer'
-require_dependency 'search/grouped_search_results'
-
 class SimilarTopicsController < ApplicationController
 
   class SimilarTopic

app/controllers/site_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'site_serializer'
-
 class SiteController < ApplicationController
   layout false
   skip_before_action :preload_json, :check_xhr

app/controllers/static_controller.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'distributed_memoizer'
-require_dependency 'file_helper'
-
 class StaticController < ApplicationController
 
   skip_before_action :check_xhr, :redirect_to_login_if_required

app/controllers/steps_controller.rb

@@ -1,9 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'wizard'
-require_dependency 'wizard/builder'
-require_dependency 'wizard/step_updater'
-
 class StepsController < ApplicationController
   requires_login
 

app/controllers/tags_controller.rb

@@ -1,10 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'topic_list_responder'
-require_dependency 'topic_query_params'
-require_dependency 'topics_bulk_action'
-require_dependency 'topic_query'
-
 class TagsController < ::ApplicationController
   include TopicListResponder
   include TopicQueryParams

app/controllers/topics_controller.rb

@@ -1,14 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'topic_view'
-require_dependency 'promotion'
-require_dependency 'url_helper'
-require_dependency 'topics_bulk_action'
-require_dependency 'discourse_event'
-require_dependency 'rate_limiter'
-require_dependency 'topic_publisher'
-require_dependency 'post_action_destroyer'
-
 class TopicsController < ApplicationController
   requires_login only: [
     :timings,

app/controllers/uploads_controller.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require "mini_mime"
-require_dependency 'upload_creator'
-require_dependency "file_store/local_store"
 
 class UploadsController < ApplicationController
   requires_login except: [:show, :show_short]

app/controllers/user_avatars_controller.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'letter_avatar'
-
 class UserAvatarsController < ApplicationController
 
   skip_before_action :preload_json, :redirect_to_login_if_required, :check_xhr, :verify_authenticity_token, only: [:show, :show_letter, :show_proxy_letter]

app/controllers/users/omniauth_callbacks_controller.rb

@@ -1,10 +1,6 @@
 # -*- encoding : utf-8 -*-
 # frozen_string_literal: true
 
-require_dependency 'email'
-require_dependency 'enum'
-require_dependency 'user_name_suggester'
-
 class Users::OmniauthCallbacksController < ApplicationController
 
   skip_before_action :redirect_to_login_if_required

app/controllers/users_controller.rb

@@ -1,13 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'discourse_hub'
-require_dependency 'user_name_suggester'
-require_dependency 'rate_limiter'
-require_dependency 'wizard'
-require_dependency 'wizard/builder'
-require_dependency 'admin_confirmation'
-require_dependency 'webauthn/webauthn'
-
 class UsersController < ApplicationController
 
   skip_before_action :authorize_mini_profiler, only: [:avatar]

app/controllers/users_email_controller.rb

@@ -1,9 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'rate_limiter'
-require_dependency 'email_validator'
-require_dependency 'email_updater'
-
 class UsersEmailController < ApplicationController
 
   requires_login only: [:index, :update]

app/controllers/wizard_controller.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require_dependency 'wizard'
-require_dependency 'wizard/builder'
-
 class WizardController < ApplicationController
   requires_login except: [:qunit]
 

app/helpers/application_helper.rb

@@ -2,14 +2,6 @@
 # frozen_string_literal: true
 require 'current_user'
 require 'canonical_url'
-require_dependency 'guardian'
-require_dependency 'unread'
-require_dependency 'age_words'
-require_dependency 'configurable_urls'
-require_dependency 'mobile_detection'
-require_dependency 'category_badge'
-require_dependency 'global_path'
-require_dependency 'emoji'
 
 module ApplicationHelper
   include CurrentUser

app/jobs/base.rb

@@ -187,7 +187,7 @@ module Jobs
     def perform(*args)
       opts = args.extract_options!.with_indifferent_access
 
-      if Jobs.run_later?
+      if ::Jobs.run_later?
         Sidekiq.redis do |r|
           r.set('last_job_perform_at', Time.now.to_i)
         end
@@ -275,7 +275,7 @@ module Jobs
     extend MiniScheduler::Schedule
 
     def perform(*args)
-      if (Jobs::Heartbeat === self) || !Discourse.readonly_mode?
+      if (::Jobs::Heartbeat === self) || !Discourse.readonly_mode?
         super
       end
     end
@@ -290,7 +290,8 @@ module Jobs
     end
 
     # If we are able to queue a job, do it
-    if Jobs.run_later?
+
+    if ::Jobs.run_later?
       hash = {
         'class' => klass,
         'args' => [opts]
@@ -361,7 +362,3 @@ module Jobs
     end
   end
 end
-
-Dir["#{Rails.root}/app/jobs/onceoff/*.rb"].each { |file| require_dependency file }
-Dir["#{Rails.root}/app/jobs/regular/*.rb"].each { |file| require_dependency file }
-Dir["#{Rails.root}/app/jobs/scheduled/*.rb"].each { |file| require_dependency file }

app/jobs/onceoff/clean_up_post_timings.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class CleanUpPostTimings < Jobs::Onceoff
+  class CleanUpPostTimings < ::Jobs::Onceoff
 
     # Remove post timings that are remnants of previous post moves
     # or other shenanigans and don't reference a valid user or post anymore.

app/jobs/onceoff/clean_up_sidekiq_statistic.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class CleanUpSidekiqStatistic < Jobs::Onceoff
+  class CleanUpSidekiqStatistic < ::Jobs::Onceoff
     def execute_onceoff(args)
       $redis.without_namespace.del('sidekiq:sidekiq:statistic')
     end

app/jobs/onceoff/clean_up_user_export_topics.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class CleanUpUserExportTopics < Jobs::Onceoff
+  class CleanUpUserExportTopics < ::Jobs::Onceoff
     def execute_onceoff(args)
       translated_keys = I18n.available_locales.map do |l|
         I18n.with_locale(:"#{l}") { I18n.t("system_messages.csv_export_succeeded.subject_template") }

app/jobs/onceoff/clear_width_and_height.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class ClearWidthAndHeight < Jobs::Onceoff
+  class ClearWidthAndHeight < ::Jobs::Onceoff
     def execute_onceoff(args)
       # we have to clear all old uploads cause
       # we could have old versions of height / width

app/jobs/onceoff/correct_missing_dualstack_urls.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class CorrectMissingDualstackUrls < Jobs::Onceoff
+  class CorrectMissingDualstackUrls < ::Jobs::Onceoff
     def execute_onceoff(args)
       # s3 now uses dualstack urls, keep them around correctly
       # in both uploads and optimized_image tables

app/jobs/onceoff/create_tags_search_index.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class CreateTagsSearchIndex < Jobs::Onceoff
+  class CreateTagsSearchIndex < ::Jobs::Onceoff
     def execute_onceoff(args)
       DB.query('select id, name from tags').each do |t|
         SearchIndexer.update_tags_index(t.id, t.name)

app/jobs/onceoff/fix_featured_link_for_topics.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class FixFeaturedLinkForTopics < Jobs::Onceoff
+  class FixFeaturedLinkForTopics < ::Jobs::Onceoff
     def execute_onceoff(args)
       Topic.where("featured_link IS NOT NULL").find_each do |topic|
         featured_link = topic.featured_link

app/jobs/onceoff/fix_invalid_gravatar_uploads.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class FixInvalidGravatarUploads < Jobs::Onceoff
+  class FixInvalidGravatarUploads < ::Jobs::Onceoff
     def execute_onceoff(args)
       Upload.where(original_filename: "gravatar.png").find_each do |upload|
         # note, this still feels pretty expensive for a once off

app/jobs/onceoff/fix_invalid_upload_extensions.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
 
-require_dependency "upload_fixer"
-
 module Jobs
-  class FixInvalidUploadExtensions < Jobs::Onceoff
+  class FixInvalidUploadExtensions < ::Jobs::Onceoff
     def execute_onceoff(args)
       UploadFixer.fix_all_extensions
     end

app/jobs/onceoff/fix_out_of_sync_user_uploaded_avatar.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class FixOutOfSyncUserUploadedAvatar < Jobs::Onceoff
+  class FixOutOfSyncUserUploadedAvatar < ::Jobs::Onceoff
     def execute_onceoff(args)
       DB.exec(<<~SQL)
       WITH X AS (

app/jobs/onceoff/fix_posts_read.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class FixPostsRead < Jobs::Onceoff
+  class FixPostsRead < ::Jobs::Onceoff
     def execute_onceoff(args)
       # Skipping to the last post in a topic used to count all posts in the topic
       # as read in user stats. Cap the posts read count to 50 * topics_entered.

app/jobs/onceoff/fix_primary_emails_for_staged_users.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
 
-require_dependency 'user_destroyer'
-
 module Jobs
-  class FixPrimaryEmailsForStagedUsers < Jobs::Onceoff
+  class FixPrimaryEmailsForStagedUsers < ::Jobs::Onceoff
     def execute_onceoff(args)
       users = User.where(active: false, staged: true).joins(:email_tokens)
       acting_user = Discourse.system_user

app/jobs/onceoff/fix_retro_anniversary.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
 
-require_dependency 'jobs/scheduled/grant_anniversary_badges'
-
 module Jobs
 
-  class FixRetroAnniversary < Jobs::Onceoff
+  class FixRetroAnniversary < ::Jobs::Onceoff
     def execute_onceoff(args)
       return unless SiteSetting.enable_badges
 

app/jobs/onceoff/fix_s3_etags.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class FixS3Etags < Jobs::Onceoff
+  class FixS3Etags < ::Jobs::Onceoff
 
     def execute_onceoff(args)
       [Upload, OptimizedImage].each do |model|

app/jobs/onceoff/grant_emoji.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class GrantEmoji < Jobs::Onceoff
+  class GrantEmoji < ::Jobs::Onceoff
     def execute_onceoff(args)
       return unless SiteSetting.enable_badges
       to_award = {}

app/jobs/onceoff/grant_first_reply_by_email.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class GrantFirstReplyByEmail < Jobs::Onceoff
+  class GrantFirstReplyByEmail < ::Jobs::Onceoff
 
     def execute_onceoff(args)
       return unless SiteSetting.enable_badges

app/jobs/onceoff/grant_onebox.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class GrantOnebox < Jobs::Onceoff
+  class GrantOnebox < ::Jobs::Onceoff
     sidekiq_options queue: 'low'
 
     def execute_onceoff(args)

app/jobs/onceoff/init_category_tag_stats.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class InitCategoryTagStats < Jobs::Onceoff
+  class InitCategoryTagStats < ::Jobs::Onceoff
     def execute_onceoff(args)
       DB.exec "DELETE FROM category_tag_stats"
 

app/jobs/onceoff/migrate_censored_words.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class MigrateCensoredWords < Jobs::Onceoff
+  class MigrateCensoredWords < ::Jobs::Onceoff
     def execute_onceoff(args)
       row = DB.query_single("SELECT value FROM site_settings WHERE name = 'censored_words'")
       if row.count > 0

app/jobs/onceoff/migrate_custom_emojis.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
 
-require_dependency 'upload_creator'
-
 module Jobs
-  class MigrateCustomEmojis < Jobs::Onceoff
+  class MigrateCustomEmojis < ::Jobs::Onceoff
     def execute_onceoff(args)
       return if Rails.env.test?
 

app/jobs/onceoff/migrate_featured_links.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class MigrateFeaturedLinks < Jobs::Onceoff
+  class MigrateFeaturedLinks < ::Jobs::Onceoff
 
     def execute_onceoff(args)
       TopicCustomField.where(name: "featured_link").find_each do |tcf|

app/jobs/onceoff/migrate_tagging_plugin.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class MigrateTaggingPlugin < Jobs::Onceoff
+  class MigrateTaggingPlugin < ::Jobs::Onceoff
 
     def execute_onceoff(args)
       all_tags = TopicCustomField.where(name: "tags").select('DISTINCT value').all.map(&:value)

app/jobs/onceoff/migrate_upload_extensions.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class MigrateUploadExtensions < Jobs::Onceoff
+  class MigrateUploadExtensions < ::Jobs::Onceoff
     def execute_onceoff(args)
       Upload.find_each do |upload|
         upload.extension = File.extname(upload.original_filename)[1..10]

app/jobs/onceoff/migrate_url_site_settings.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class MigrateUrlSiteSettings < Jobs::Onceoff
+  class MigrateUrlSiteSettings < ::Jobs::Onceoff
     SETTINGS = [
       ['logo_url', 'logo'],
       ['logo_small_url', 'logo_small'],

app/jobs/onceoff/onceoff.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
-class Jobs::Onceoff < Jobs::Base
+require_relative '../base.rb'
+
+class Jobs::Onceoff < ::Jobs::Base
   sidekiq_options retry: false
 
   def self.name_for(klass)

app/jobs/onceoff/post_uploads_recovery.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
 
-require_dependency "upload_recovery"
-
 module Jobs
-  class PostUploadsRecovery < Jobs::Onceoff
+  class PostUploadsRecovery < ::Jobs::Onceoff
     MIN_PERIOD = 30
     MAX_PERIOD = 120
 

app/jobs/onceoff/remove_old_auto_close_jobs.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class RemoveOldAutoCloseJobs < Jobs::Onceoff
+  class RemoveOldAutoCloseJobs < ::Jobs::Onceoff
     def execute_onceoff(args)
       Jobs.cancel_scheduled_job(:close_topic)
 

app/jobs/onceoff/retro_grant_anniversary.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
 
-require_dependency 'jobs/scheduled/grant_anniversary_badges'
-
 module Jobs
 
-  class RetroGrantAnniversary < Jobs::Onceoff
+  class RetroGrantAnniversary < ::Jobs::Onceoff
     def execute_onceoff(args)
       return unless SiteSetting.enable_badges
 

app/jobs/onceoff/retro_recent_time_read.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class RetroRecentTimeRead < Jobs::Onceoff
+  class RetroRecentTimeRead < ::Jobs::Onceoff
     def execute_onceoff(args)
       # update past records by evenly distributing total time reading among each post read
       sql = <<~SQL

app/jobs/regular/admin_confirmation_email.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
 
-require_dependency 'email/sender'
-
 module Jobs
-  class AdminConfirmationEmail < Jobs::Base
+  class AdminConfirmationEmail < ::Jobs::Base
     sidekiq_options queue: 'critical'
 
     def execute(args)

app/jobs/regular/anonymize_user.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class AnonymizeUser < Jobs::Base
+  class AnonymizeUser < ::Jobs::Base
 
     sidekiq_options queue: 'low'
 

app/jobs/regular/automatic_group_membership.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class AutomaticGroupMembership < Jobs::Base
+  class AutomaticGroupMembership < ::Jobs::Base
 
     def execute(args)
       group_id = args[:group_id]

app/jobs/regular/backup_chunks_merger.rb

@@ -1,11 +1,8 @@
 # frozen_string_literal: true
 
-require_dependency "backup_restore/local_backup_store"
-require_dependency "backup_restore/backup_store"
-
 module Jobs
 
-  class BackupChunksMerger < Jobs::Base
+  class BackupChunksMerger < ::Jobs::Base
     sidekiq_options queue: 'critical', retry: false
 
     def execute(args)

app/jobs/regular/bulk_grant_trust_level.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class BulkGrantTrustLevel < Jobs::Base
+  class BulkGrantTrustLevel < ::Jobs::Base
 
     def execute(args)
       trust_level = args[:trust_level]

app/jobs/regular/bulk_invite.rb

@@ -1,10 +1,7 @@
 # frozen_string_literal: true
 
-require_dependency 'system_message'
-
 module Jobs
-
-  class BulkInvite < Jobs::Base
+  class BulkInvite < ::Jobs::Base
     sidekiq_options retry: false
 
     def initialize

app/jobs/regular/bump_topic.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class BumpTopic < Jobs::Base
+  class BumpTopic < ::Jobs::Base
 
     def execute(args)
       topic_timer = TopicTimer.find_by(id: args[:topic_timer_id] || args[:topic_status_update_id])

app/jobs/regular/confirm_sns_subscription.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class ConfirmSnsSubscription < Jobs::Base
+  class ConfirmSnsSubscription < ::Jobs::Base
     sidekiq_options retry: false
 
     def execute(args)

app/jobs/regular/crawl_topic_link.rb

@@ -3,11 +3,9 @@
 require 'open-uri'
 require 'nokogiri'
 require 'excon'
-require_dependency 'retrieve_title'
-require_dependency 'topic_link'
 
 module Jobs
-  class CrawlTopicLink < Jobs::Base
+  class CrawlTopicLink < ::Jobs::Base
 
     sidekiq_options queue: 'low'
 

app/jobs/regular/create_avatar_thumbnails.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class CreateAvatarThumbnails < Jobs::Base
+  class CreateAvatarThumbnails < ::Jobs::Base
     sidekiq_options queue: 'low'
 
     def execute(args)

app/jobs/regular/create_backup.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require "backup_restore/backup_restore"
+require "backup_restore"
 
 module Jobs
-  class CreateBackup < Jobs::Base
+  class CreateBackup < ::Jobs::Base
     sidekiq_options retry: false
 
     def execute(args)

app/jobs/regular/create_user_reviewable.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class Jobs::CreateUserReviewable < Jobs::Base
+class Jobs::CreateUserReviewable < ::Jobs::Base
   attr_reader :reviewable
 
   def execute(args)

app/jobs/regular/critical_user_email.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 # base.rb uses this style of require, so maintain usage of it here
-require_dependency "#{Rails.root}/app/jobs/regular/user_email.rb"
 
 module Jobs
   class CriticalUserEmail < UserEmail

app/jobs/regular/delete_inaccessible_notifications.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class DeleteInaccessibleNotifications < Jobs::Base
+  class DeleteInaccessibleNotifications < ::Jobs::Base
     def execute(args)
       raise Discourse::InvalidParameters.new(:topic_id) if args[:topic_id].blank?
 

app/jobs/regular/delete_topic.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class DeleteTopic < Jobs::Base
+  class DeleteTopic < ::Jobs::Base
 
     def execute(args)
       topic_timer = TopicTimer.find_by(id: args[:topic_timer_id] || args[:topic_status_update_id])

app/jobs/regular/download_avatar_from_url.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class DownloadAvatarFromUrl < Jobs::Base
+  class DownloadAvatarFromUrl < ::Jobs::Base
     sidekiq_options retry: false
 
     def execute(args)

app/jobs/regular/download_backup_email.rb

@@ -1,11 +1,8 @@
 # frozen_string_literal: true
 
-require_dependency 'email/sender'
-require_dependency "email_backup_token"
-
 module Jobs
 
-  class DownloadBackupEmail < Jobs::Base
+  class DownloadBackupEmail < ::Jobs::Base
 
     sidekiq_options queue: 'critical'
 

app/jobs/regular/download_profile_background_from_url.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class DownloadProfileBackgroundFromUrl < Jobs::Base
+  class DownloadProfileBackgroundFromUrl < ::Jobs::Base
     sidekiq_options retry: false
 
     def execute(args)

app/jobs/regular/emit_web_hook_event.rb

@@ -3,7 +3,7 @@
 require 'excon'
 
 module Jobs
-  class EmitWebHookEvent < Jobs::Base
+  class EmitWebHookEvent < ::Jobs::Base
     PING_EVENT = 'ping'.freeze
     MAX_RETRY_COUNT = 4.freeze
     RETRY_BACKOFF = 5

app/jobs/regular/enable_bootstrap_mode.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class EnableBootstrapMode < Jobs::Base
+  class EnableBootstrapMode < ::Jobs::Base
     sidekiq_options queue: 'critical'
 
     def execute(args)

app/jobs/regular/export_csv_file.rb

@@ -2,13 +2,10 @@
 
 require 'csv'
 require 'zip'
-require_dependency 'system_message'
-require_dependency 'upload_creator'
-require_dependency 'upload_markdown'
 
 module Jobs
 
-  class ExportCsvFile < Jobs::Base
+  class ExportCsvFile < ::Jobs::Base
     sidekiq_options retry: false
 
     HEADER_ATTRS_FOR ||= HashWithIndifferentAccess.new(

app/jobs/regular/feature_topic_users.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class FeatureTopicUsers < Jobs::Base
+  class FeatureTopicUsers < ::Jobs::Base
 
     def execute(args)
       topic_id = args[:topic_id]

app/jobs/regular/invite_email.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
 
-require_dependency 'email/sender'
-
 module Jobs
 
   # Asynchronously send an email
-  class InviteEmail < Jobs::Base
+  class InviteEmail < ::Jobs::Base
 
     def execute(args)
       raise Discourse::InvalidParameters.new(:invite_id) unless args[:invite_id].present?

app/jobs/regular/invite_password_instructions_email.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
 
-require_dependency 'email/sender'
-
 module Jobs
 
   # Asynchronously send an email
-  class InvitePasswordInstructionsEmail < Jobs::Base
+  class InvitePasswordInstructionsEmail < ::Jobs::Base
 
     def execute(args)
       raise Discourse::InvalidParameters.new(:username) unless args[:username].present?

app/jobs/regular/notify_category_change.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
 
-require_dependency "post_alerter"
-
 module Jobs
-  class NotifyCategoryChange < Jobs::Base
+  class NotifyCategoryChange < ::Jobs::Base
     def execute(args)
       post = Post.find_by(id: args[:post_id])
 

app/jobs/regular/notify_mailing_list_subscribers.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
 
-require_dependency 'post'
-
 module Jobs
 
-  class NotifyMailingListSubscribers < Jobs::Base
+  class NotifyMailingListSubscribers < ::Jobs::Base
     include Skippable
 
     RETRY_TIMES = [5.minute, 15.minute, 30.minute, 45.minute, 90.minute, 180.minute, 300.minute]

app/jobs/regular/notify_moved_posts.rb

@@ -2,7 +2,7 @@
 
 module Jobs
 
-  class NotifyMovedPosts < Jobs::Base
+  class NotifyMovedPosts < ::Jobs::Base
 
     def execute(args)
       raise Discourse::InvalidParameters.new(:post_ids) if args[:post_ids].blank?

app/jobs/regular/notify_post_revision.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Jobs
-  class NotifyPostRevision < Jobs::Base
+  class NotifyPostRevision < ::Jobs::Base
     def execute(args)
       raise Discourse::InvalidParameters.new(:user_ids) unless args[:user_ids]
 

app/jobs/regular/notify_reviewable.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class Jobs::NotifyReviewable < Jobs::Base
+class Jobs::NotifyReviewable < ::Jobs::Base
 
   def execute(args)
     reviewable = Reviewable.find_by(id: args[:reviewable_id])