FIX: Support pausing GIFs for giphy/tenor oneboxes (#13194)

lib/onebox/engine.rb

@@ -171,7 +171,7 @@ require_relative "engine/imgur_onebox"
 require_relative "engine/pastebin_onebox"
 require_relative "engine/slides_onebox"
 require_relative "engine/xkcd_onebox"
-require_relative "engine/giphy_onebox"
+require_relative "engine/animated_image_onebox"
 require_relative "engine/gfycat_onebox"
 require_relative "engine/typeform_onebox"
 require_relative "engine/vimeo_onebox"

lib/onebox/engine/animated_image_onebox.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module Onebox
+  module Engine
+    class AnimatedImageOnebox
+      include Engine
+      include StandardEmbed
+
+      matches_regexp(/^https?:\/\/.*(giphy\.com|gph\.is|tenor\.com)\//)
+      always_https
+
+      def to_html
+        og = get_opengraph
+        "<img src='#{og.image}' width='#{og.image_width}' height='#{og.image_height}' class='animated onebox' #{og.title_attr}>"
+      end
+    end
+  end
+end

lib/onebox/engine/giphy_onebox.rb

@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-module Onebox
-  module Engine
-    class GiphyOnebox
-      include Engine
-      include StandardEmbed
-
-      matches_regexp(/^https?:\/\/(giphy\.com\/gifs|gph\.is)\//)
-      always_https
-
-      def to_html
-        oembed = get_oembed
-
-        <<-HTML
-          <a href="#{oembed.url}" target="_blank" rel="noopener" class="onebox">
-            <img src="#{oembed.url}" width="#{oembed.width}" height="#{oembed.height}" #{oembed.title_attr}>
-          </a>
-        HTML
-      end
-    end
-  end
-end

spec/lib/onebox/engine/animated_image_onebox_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+describe Onebox::Engine::AnimatedImageOnebox do
+  let(:giphy) { "http://gph.is/15bRbWf" }
+  let(:tenor) { "https://tenor.com/bb3fQ.gif" }
+
+  before do
+    @previous_options = Onebox.options.to_h
+    Onebox.options = { redirect_limit: 0 }
+    stub_request(:get, giphy).to_return(status: 200, body: onebox_response("giphy"))
+    stub_request(:get, tenor).to_return(status: 200, body: onebox_response("tenor"))
+  end
+
+  after do
+    Onebox.options = @previous_options
+  end
+
+  it "works for giphy short URLs" do
+    html = described_class.new(giphy).to_html
+    expect(html).to include("img")
+    expect(html).to include("class='animated onebox'")
+  end
+
+  it "works for tenor URLs" do
+    html = described_class.new(tenor).to_html
+    expect(html).to include("img")
+    expect(html).to include("class='animated onebox'")
+  end
+end