github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 15:25:35 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Attempt to fix a flaky spec (#29155)

Browse Source 
We some times get the following failure on Github CI:

```
expected StandardError with message matching /some.host/, got #<Socket::ResolutionError: getaddrinfo: Temporary failure in name resolution> with backtrace:
```
This commit is contained in:
Alan Guo Xiang Tan 2024-10-10 17:19:53 +08:00 committed by GitHub
parent 9124d6ba5a
commit 47f383d1ac
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
spec/integration/smtp_spec.rb
View File

@ -12,17 +12,15 @@ RSpec.describe "SMTP Settings Integration" do
ActionMailer::Base.delivery_method = @original_action_mailer_delivery_method
end
it "should send out the email successfully using the SMTP settings" do
global_setting :smtp_address, "some.host"
it "should attempt to send out an email without raising any SMTP argument errors" do
global_setting :smtp_address, "1.2.3.4"
global_setting :smtp_port, 12_345
global_setting :smtp_open_timeout, 0.00001
ActionMailer::Base.smtp_settings = GlobalSetting.smtp_settings
message = TestMailer.send_test("some_email")
expect do Email::Sender.new(message, :test_message).send end.to raise_error(
StandardError,
/some.host/,
)
expect do Email::Sender.new(message, :test_message).send end.to raise_error(Net::OpenTimeout)
end
end