github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 18:53:44 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

DEV: adds afterCreate/beforeUpdate hooks to rest models (#9253)

Browse Source 
We already have beforeCreate and afterUpdate and it seems these hooks can be useful and it's also unexpected to not have parity on this.
This commit is contained in:
Joffrey JAFFEUX 2020-03-23 16:58:40 +01:00 committed by GitHub
parent e58f0adfcc
commit 48c1de4836
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/discourse/models/rest.js
View File

@ -9,6 +9,9 @@ const RestModel = EmberObject.extend({
isSaving: false,
beforeCreate() {},
afterCreate() {},
beforeUpdate() {},
afterUpdate() {},
update(props) {
@ -18,6 +21,8 @@ const RestModel = EmberObject.extend({
props = props || this.updateProperties();
this.beforeUpdate(props);
this.set("isSaving", true);
return this.store
.update(this.__type, this.id, props)
@ -65,6 +70,7 @@ const RestModel = EmberObject.extend({
this.set("__state", "created");
}
this.afterCreate(res);
res.target = this;
return res;
})

8
test/javascripts/models/rest-model-test.js.es6
View File

@ -24,10 +24,14 @@ QUnit.test("update", async assert => {
assert.equal(widget.get("name"), "Trout Lure");
assert.ok(!widget.get("isSaving"), "it is not saving");
const spyBeforeUpdate = sandbox.spy(widget, "beforeUpdate");
const spyAfterUpdate = sandbox.spy(widget, "afterUpdate");
const promise = widget.update({ name: "new name" });
assert.ok(widget.get("isSaving"), "it is saving");
assert.ok(spyBeforeUpdate.calledOn(widget));
const result = await promise;
assert.ok(spyAfterUpdate.calledOn(widget));
assert.ok(!widget.get("isSaving"), "it is no longer saving");
assert.equal(widget.get("name"), "new name");
@ -61,10 +65,14 @@ QUnit.test("save new", async assert => {
assert.ok(!widget.get("isCreated"), "it is not created");
assert.ok(!widget.get("isSaving"), "it is not saving");
const spyBeforeCreate = sandbox.spy(widget, "beforeCreate");
const spyAfterCreate = sandbox.spy(widget, "afterCreate");
const promise = widget.save({ name: "Evil Widget" });
assert.ok(widget.get("isSaving"), "it is not saving");
assert.ok(spyBeforeCreate.calledOn(widget));
const result = await promise;
assert.ok(spyAfterCreate.calledOn(widget));
assert.ok(!widget.get("isSaving"), "it is no longer saving");
assert.ok(widget.get("id"), "it has an id");
assert.ok(widget.get("name"), "Evil Widget");