github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 20:20:43 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Show select-kit deprecations in non-dev envs (#21297)

Browse Source 
We should have them in CI ;) (silenced for now, fixing them is not a priority)
This commit is contained in:
Jarek Radosz 2023-04-28 17:58:41 +02:00 committed by GitHub
parent a67c96438c
commit 4a08c23965
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/discourse/config/deprecation-workflow.js
View File

@ -8,5 +8,6 @@ globalThis.deprecationWorkflow.config = {
{ handler: "silence", matchId: "routing.transition-methods" }, { handler: "silence", matchId: "routing.transition-methods" },
{ handler: "silence", matchId: "route-disconnect-outlet" }, { handler: "silence", matchId: "route-disconnect-outlet" },
{ handler: "silence", matchId: "this-property-fallback" }, { handler: "silence", matchId: "this-property-fallback" },
{ handler: "silence", matchId: "discourse.select-kit" },
], ],
}; };

16
app/assets/javascripts/select-kit/addon/components/select-kit.js
View File

@ -1083,17 +1083,11 @@ export default Component.extend(
}, },
_deprecated(text) { _deprecated(text) {
const discourseSetup = document.getElementById("data-discourse-setup"); deprecated(text, {
if ( since: "v2.4.0",
discourseSetup && dropFrom: "2.9.0.beta1",
discourseSetup.getAttribute("data-environment") === "development" id: "discourse.select-kit",
) { });
deprecated(text, {
since: "v2.4.0",
dropFrom: "2.9.0.beta1",
id: "discourse.select-kit",
});
}
}, },
_deprecateValueAttribute() { _deprecateValueAttribute() {