From 4b84236bc11773434be0aad7953126ec0600ed23 Mon Sep 17 00:00:00 2001 From: Martin Brennan Date: Wed, 24 Aug 2022 16:01:29 +1000 Subject: [PATCH] PERF: Rely on preload for first_post for TopicBookmarkable (#18066) In 49a70a37f10edb05fd98ac9935f72aeb00a842d2 I removed the topic: :posts preload for TopicBookmarkable, but did not update the UserTopicBookmarkSerializer to reflect this, which was causing up to multi-hundred millisecond queries to be made for each topic bookmark based on the size of the topic. --- app/serializers/user_topic_bookmark_serializer.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/serializers/user_topic_bookmark_serializer.rb b/app/serializers/user_topic_bookmark_serializer.rb index 84d14d1620a..477c744f1e7 100644 --- a/app/serializers/user_topic_bookmark_serializer.rb +++ b/app/serializers/user_topic_bookmark_serializer.rb @@ -11,7 +11,7 @@ class UserTopicBookmarkSerializer < UserPostTopicBookmarkBaseSerializer end def first_post - @first_post ||= topic.posts.find { |post| post.post_number == 1 } + @first_post ||= topic.first_post end def deleted