github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-27 12:03:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Avoid transitioning when a chat thread component is destroyed (#22457)

Browse Source 
Why this change?

Before this commit, there is a chance that we will transition the user
to a different route if the chat thread component has been destroyed
prior to the request for fetching messasges in a chat thread returning.

This commit makes it such that we simply ignore the request if the chat
thread component has been destroyed.

We believe this is the cause of the flaky system tests in plugins/chat/spec/system/navigation_spec.rb
which we've been seeing on CI.
This commit is contained in:
Alan Guo Xiang Tan 2023-07-06 10:53:28 +08:00 committed by GitHub
parent ff38bccb80
commit 4c810703c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/chat/assets/javascripts/discourse/components/chat-thread.js
View File

@ -166,10 +166,11 @@ export default class ChatThreadPanel extends Component {
return this.chatApi
.channel(this.args.thread.channel.id, findArgs)
.then((result) => {
if (
this._selfDeleted ||
this.args.thread.channel.id !== result.meta.channel_id
) {
if (this._selfDeleted) {
return;
}
if (this.args.thread.channel.id !== result.meta.channel_id) {
if (this.chatHistory.previousRoute?.name === "chat.channel.index") {
this.router.transitionTo(
"chat.channel",