github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-09 03:35:26 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Move "What's new?" link in admin sidebar to root section (#30144)

Browse Source 
This is so the link is more visible, instead of being
buried in the Account section.
This commit is contained in:
Martin Brennan 2024-12-09 10:01:09 +10:00 committed by GitHub
parent 97e593bfbf
commit 4ddf7e61f9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/app/lib/sidebar/admin-nav-map.js
View File

@ -11,14 +11,6 @@ export const ADMIN_NAV_MAP = [
label: "admin.account.sidebar_link.backups", label: "admin.account.sidebar_link.backups",
icon: "box-archive", icon: "box-archive",
}, },
{
name: "admin_whats_new",
route: "admin.whatsNew",
label: "admin.account.sidebar_link.whats_new.title",
icon: "gift",
keywords: "admin.account.sidebar_link.whats_new.keywords",
moderator: true,
},
], ],
}, },
{ {

8
app/assets/javascripts/discourse/app/lib/sidebar/admin-sidebar.js
View File

@ -208,6 +208,14 @@ export function useAdminNavConfig(navMap) {
label: "admin.advanced.sidebar_link.all_site_settings", label: "admin.advanced.sidebar_link.all_site_settings",
icon: "gear", icon: "gear",
}, },
{
name: "admin_whats_new",
route: "admin.whatsNew",
label: "admin.account.sidebar_link.whats_new.title",
icon: "gift",
keywords: "admin.account.sidebar_link.whats_new.keywords",
moderator: true,
},
], ],
}, },
]; ];

16
spec/system/admin_sidebar_navigation_spec.rb
View File

@ -50,8 +50,8 @@ describe "Admin Revamp | Sidebar Navigation", type: :system do
it "collapses sections by default" do it "collapses sections by default" do
visit("/admin") visit("/admin")
links = page.all(".sidebar-section-link-content-text") links = page.all(".sidebar-section-link-content-text")
expect(links.count).to eq(3) expect(links.count).to eq(4)
expect(links.map(&:text)).to eq(["Dashboard", "Users", "All Site Settings"]) expect(links.map(&:text)).to eq(["Dashboard", "Users", "All Site Settings", "What's New"])
end end
context "when on mobile" do context "when on mobile" do
@ -173,8 +173,8 @@ describe "Admin Revamp | Sidebar Navigation", type: :system do
it "temporarily expands section when filter" do it "temporarily expands section when filter" do
visit("/admin") visit("/admin")
links = page.all(".sidebar-section-link-content-text") links = page.all(".sidebar-section-link-content-text")
expect(links.count).to eq(3) expect(links.count).to eq(4)
expect(links.map(&:text)).to eq(["Dashboard", "Users", "All Site Settings"]) expect(links.map(&:text)).to eq(["Dashboard", "Users", "All Site Settings", "What's New"])
filter.filter("ie") filter.filter("ie")
links = page.all(".sidebar-section-link-content-text") links = page.all(".sidebar-section-link-content-text")
@ -183,8 +183,8 @@ describe "Admin Revamp | Sidebar Navigation", type: :system do
filter.filter("") filter.filter("")
links = page.all(".sidebar-section-link-content-text") links = page.all(".sidebar-section-link-content-text")
expect(links.count).to eq(3) expect(links.count).to eq(4)
expect(links.map(&:text)).to eq(["Dashboard", "Users", "All Site Settings"]) expect(links.map(&:text)).to eq(["Dashboard", "Users", "All Site Settings", "What's New"])
end end
it "allows further filtering of site settings or users if links do not show results" do it "allows further filtering of site settings or users if links do not show results" do
@ -223,9 +223,9 @@ describe "Admin Revamp | Sidebar Navigation", type: :system do
expect(page).to have_selector(".sidebar-section-link-content-text", minimum: 50) expect(page).to have_selector(".sidebar-section-link-content-text", minimum: 50)
sidebar.toggle_all_sections sidebar.toggle_all_sections
expect(page).to have_selector(".sidebar-section-link-content-text", count: 3) expect(page).to have_selector(".sidebar-section-link-content-text", count: 4)
expect(all(".sidebar-section-link-content-text").map(&:text)).to eq( expect(all(".sidebar-section-link-content-text").map(&:text)).to eq(
["Dashboard", "Users", "All Site Settings"], ["Dashboard", "Users", "All Site Settings", "What's New"],
) )
sidebar.toggle_all_sections sidebar.toggle_all_sections