github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 06:04:11 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Update featured badge ranking when mass-awarding badges

Browse Source 
Follow-up to cff6e941de
This commit is contained in:
David Taylor 2020-01-14 14:39:20 +00:00
parent cff6e941de
commit 4fdfc2665d
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/services/badge_granter.rb
View File

@ -28,6 +28,8 @@ class BadgeGranter
user_id: user.id, user_id: user.id,
badge_id: badge.id badge_id: badge.id
) )
UserBadge.update_featured_ranks!(user.id)
end end
end end

11
spec/jobs/mass_award_badge_spec.rb
View File

@ -28,5 +28,16 @@ describe Jobs::MassAwardBadge do
expect(Notification.exists?(user: user)).to eq(true) expect(Notification.exists?(user: user)).to eq(true)
expect(UserBadge.where.not(notification_id: nil).exists?(user: user, badge: badge)).to eq(true) expect(UserBadge.where.not(notification_id: nil).exists?(user: user, badge: badge)).to eq(true)
end end
it 'updates badge ranks correctly' do
user_2 = Fabricate(:user)
UserBadge.create!(badge_id: Badge::Member, user: user, granted_by: Discourse.system_user, granted_at: Time.now)
subject.execute(user_emails: [user.email, user_2.email], badge_id: badge.id)
expect(UserBadge.find_by(user: user, badge: badge).featured_rank).to eq(2)
expect(UserBadge.find_by(user: user_2, badge: badge).featured_rank).to eq(1)
end
end end
end end