github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-27 17:53:40 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #4469 from xfalcox/better-facebook-avatars

Browse Source 
Uses higher resolution pictures when importing avatars from Facebook
This commit is contained in:
Jeff Atwood 2016-09-28 18:26:48 +02:00 committed by GitHub
commit 50d4f9d016
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/auth/facebook_authenticator.rb
View File

@ -1,5 +1,7 @@
class Auth::FacebookAuthenticator < Auth::Authenticator class Auth::FacebookAuthenticator < Auth::Authenticator
AVATAR_SIZE = 480
def name def name
"facebook" "facebook"
end end
@ -31,7 +33,8 @@ class Auth::FacebookAuthenticator < Auth::Authenticator
user = result.user user = result.user
if user && (!user.user_avatar || user.user_avatar.custom_upload_id.nil?) if user && (!user.user_avatar || user.user_avatar.custom_upload_id.nil?)
if (avatar_url = facebook_hash[:avatar_url]).present? if (avatar_url = facebook_hash[:avatar_url]).present?
UserAvatar.import_url_for_user(avatar_url, user, override_gravatar: false) avatar_url_with_parameters = add_avatar_parameters(avatar_url)
UserAvatar.import_url_for_user(avatar_url_with_parameters, user, override_gravatar: false)
end end
end end
@ -65,7 +68,8 @@ class Auth::FacebookAuthenticator < Auth::Authenticator
if (avatar_url = data[:avatar_url]).present? if (avatar_url = data[:avatar_url]).present?
UserAvatar.import_url_for_user(avatar_url, user) avatar_url_with_parameters = add_avatar_parameters(avatar_url)
UserAvatar.import_url_for_user(avatar_url_with_parameters, user)
user.save user.save
end end
@ -130,5 +134,8 @@ class Auth::FacebookAuthenticator < Auth::Authenticator
end end
def add_avatar_parameters(avatar_url)
"#{avatar_url}?height=#{AVATAR_SIZE}&width=#{AVATAR_SIZE}"
end
end end