github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-19 10:39:01 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Memoize group find when adding users to groups (#30296)

Browse Source
This commit is contained in:
Natalie Tay 2024-12-16 17:47:24 +08:00 committed by GitHub
parent a141a096d1
commit 537f09912e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/automation/lib/discourse_automation/scripts/add_user_to_group_through_custom_field.rb
View File

@ -22,6 +22,7 @@ DiscourseAutomation::Scriptable.add(
# mapping of group full_names to ids for quick lookup # mapping of group full_names to ids for quick lookup
group_ids_by_name = Group.where.not(full_name: [nil, ""]).pluck(:full_name, :id).to_h group_ids_by_name = Group.where.not(full_name: [nil, ""]).pluck(:full_name, :id).to_h
groups_by_id = {}
# find users with the custom field who aren't in their designated group # find users with the custom field who aren't in their designated group
User User
@ -37,7 +38,7 @@ DiscourseAutomation::Scriptable.add(
.find_each do |user| .find_each do |user|
next unless group_id = group_ids_by_name[user.group_name] next unless group_id = group_ids_by_name[user.group_name]
group = Group.find(group_id) group = groups_by_id[group_id] ||= Group.find(group_id)
group.add(user) group.add(user)
GroupActionLogger.new(Discourse.system_user, group).log_add_user_to_group(user) GroupActionLogger.new(Discourse.system_user, group).log_add_user_to_group(user)
end end