github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-29 03:23:43 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: discourse remap: fix output to avoid UX issue (#24905)

Browse Source 
Before this commit, this output is possible:

```
Rewriting all occurrences of STRING1 to STRING2

THIS TASK WILL REWRITE DATA, ARE YOU SURE (type YES)
WILL RUN ON ALL 1 DBS
```

Which, when run from a script, might lead one to believe that YES was
automatically inserted into STDIN and the script is continuing.

Turns out this isn't the case so the obvious expectation is broken.

This commit swaps the order of those last lines to make it clear that
the script is blocked on input.
This commit is contained in:
Leonardo Mosquera 2023-12-14 16:30:14 -03:00 committed by GitHub
parent ca3792221a
commit 5417c4fac0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
script/discourse
View File

@ -42,8 +42,8 @@ class DiscourseCLI < Thor
else else
puts "Rewriting all occurrences of #{from} to #{to}" puts "Rewriting all occurrences of #{from} to #{to}"
end end
puts "THIS TASK WILL REWRITE DATA, ARE YOU SURE (type YES)"
puts "WILL RUN ON ALL #{RailsMultisite::ConnectionManagement.all_dbs.length} DBS" if options[:global] puts "WILL RUN ON ALL #{RailsMultisite::ConnectionManagement.all_dbs.length} DBS" if options[:global]
puts "THIS TASK WILL REWRITE DATA, ARE YOU SURE (type YES)"
text = STDIN.gets text = STDIN.gets
if text.strip.upcase != "YES" if text.strip.upcase != "YES"
puts "aborting." puts "aborting."