github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-24 07:32:11 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Improve checking for selected text (#30967)

Browse Source 
After you've selected and deselected text, `selection.rangeCount` will
return `true` on future events. Checking for `selection.toString` is
more robust.

Followup to f1bdd86a8c9bec03b962167c37963b1d11d0e5ea
This commit is contained in:
Penar Musaraj 2025-02-07 12:13:39 -05:00 committed by GitHub
parent 6595b11e25
commit 54a52e5691
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/app/lib/composer/composer-position.js
View File

@ -14,8 +14,7 @@ export function setupComposerPosition(editor) {
applyBehaviorTransformer("composer-position:editor-touch-move", () => {
const notScrollable = editor.scrollHeight <= editor.clientHeight;
const selection = window.getSelection();
if (notScrollable && selection.rangeCount === 0) {
if (notScrollable && selection.toString() === "") {
event.preventDefault();
event.stopPropagation();
}