github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 14:38:17 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: replace unitless 0 in CSS calc() with '0px' (#20689)

Browse Source 
Using the unitless number 0 in CSS calc() functions is recognized as invalid (tested in Chrome 110 & Firefox 111).
In this code, this would disable the style definition for the 'height' property when one of the custom properties is undefined and the fallback '0' is used.
For more insight on this topic. see https://stackoverflow.com/questions/55406001/why-doesnt-css-calc-work-when-using-0-inside-the-equation
This commit is contained in:
Dominik Schlipper 2023-03-20 21:06:49 +01:00 committed by GitHub
parent 62e7c72126
commit 54eaae4326
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/stylesheets/common/base/sidebar.scss
View File

@ -31,9 +31,9 @@
.footer-nav-ipad & {
top: calc(var(--header-offset) + var(--footer-nav-height));
height: calc(100vh - var(--header-offset, 0) - var(--footer-nav-height, 0));
height: calc(100vh - var(--header-offset, 0px) - var(--footer-nav-height, 0px));
}
height: calc(100vh - var(--header-offset, 0));
height: calc(100vh - var(--header-offset, 0px));
align-self: start;
overflow-y: auto;
@ -46,7 +46,7 @@
padding: 0;
overflow-x: hidden;
// allows sidebar to scroll to the bottom when the composer is open
height: calc(100% - var(--composer-height, 0));
height: calc(100% - var(--composer-height, 0px));
}
.sidebar-sections {