github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 08:36:42 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

REFACTOR: Remove _.range and use ES6 instead

Browse Source
This commit is contained in:
Robin Ward 2020-08-31 16:34:14 -04:00
parent 115b3b6921
commit 55c9c54b8b
4 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/discourse/app/models/composer.js
View File

@ -23,7 +23,6 @@ import Site from "discourse/models/site";
import User from "discourse/models/user";
import deprecated from "discourse-common/lib/deprecated";
import bootbox from "bootbox";
import { isEmpty } from "@ember/utils";
// The actions the composer can take
export const CREATE_TOPIC = "createTopic",

4
app/assets/javascripts/discourse/app/models/post-stream.js
View File

@ -362,7 +362,9 @@ export default RestModel.extend({
if (this.isMegaTopic) {
this.set("loadingBelow", true);
const fakePostIds = _.range(-1, -this.get("topic.chunk_size"), -1);
const fakePostIds = [
...Array(this.get("topic.chunk_size") - 1).keys()
].map(i => -i - 1);
postsWithPlaceholders.appending(fakePostIds);
return this.fetchNextWindow(

9
plugins/poll/assets/javascripts/controllers/poll-ui-builder.js.es6
View File

@ -334,10 +334,11 @@ export default Controller.extend({
return EmberObject.create(options);
},
_comboboxOptions(start_index, end_index) {
return _.range(start_index, end_index).map(number => {
return { value: number, name: number };
});
_comboboxOptions(startIndex, endIndex) {
return [...Array(endIndex - startIndex).keys()].map(number => ({
value: number + startIndex,
name: number + startIndex
}));
},
_setupPoll() {

16
test/javascripts/helpers/create-pretender.js
View File

@ -521,17 +521,15 @@ export function applyDefaultHandlers(pretender) {
post_number: parseInt(p, 10)
}));
} else if (postNumber && request.queryParams.asc === "true") {
posts = _.range(postNumber + 1, postNumber + 6).map(p => ({
id: parseInt(p, 10),
post_number: parseInt(p, 10)
posts = [...Array(5).keys()].map(p => ({
id: p + postNumber + 1,
post_number: p + postNumber + 1
}));
} else if (postNumber && request.queryParams.asc === "false") {
posts = _.range(postNumber - 5, postNumber)
.reverse()
.map(p => ({
id: parseInt(p, 10),
post_number: parseInt(p, 10)
}));
posts = [...Array(5).keys()].map(p => ({
id: postNumber - p - 1,
post_number: postNumber - p - 1
}));
}
return response(200, { post_stream: { posts } });