github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-18 16:02:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Highlight details text.

Browse Source
This commit is contained in:
Guo Xiang Tan 2016-06-20 08:43:12 +08:00
parent d7bc8ec752
commit 58b7f214b0
No known key found for this signature in database
GPG Key ID: 19C321C8952B0F72
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/discourse-details/assets/javascripts/initializers/apply-details.js.es6
View File

@ -17,9 +17,9 @@ function initializeDetails(api) {
actions: { actions: {
insertDetails() { insertDetails() {
this.get("toolbarEvent").applySurround( this.get("toolbarEvent").applySurround(
"[details=", `[details=${I18n.t("composer.details_title")}]`,
`]${I18n.t("composer.details_text")}[/details]`, "[/details]",
"details_title") "details_text")
; ;
} }
} }

18
plugins/discourse-details/test/javascripts/acceptance/details-button-test.js.es6
View File

@ -39,13 +39,13 @@ test('details button', () => {
andThen(() => { andThen(() => {
equal( equal(
find(".d-editor-input").val(), find(".d-editor-input").val(),
`[details=This is my title]${I18n.t("composer.details_text")}[/details]`, `[details=${I18n.t("composer.details_title")}]This is my title[/details]`,
'it should contain the right output' 'it should contain the right output'
); );
const textarea = findTextarea(); const textarea = findTextarea();
equal(textarea.selectionStart, 9, 'it should start highlighting at the right position'); equal(textarea.selectionStart, 17, 'it should start highlighting at the right position');
equal(textarea.selectionEnd, 25, 'it should end highlighting at the right position'); equal(textarea.selectionEnd, 33, 'it should end highlighting at the right position');
}); });
fillIn('.d-editor-input', "Before some text in between After"); fillIn('.d-editor-input', "Before some text in between After");
@ -62,13 +62,13 @@ test('details button', () => {
andThen(() => { andThen(() => {
equal( equal(
find(".d-editor-input").val(), find(".d-editor-input").val(),
`Before [details=some text in between]${I18n.t("composer.details_text")}[/details] After`, `Before [details=${I18n.t("composer.details_title")}]some text in between[/details] After`,
'it should contain the right output' 'it should contain the right output'
); );
const textarea = findTextarea(); const textarea = findTextarea();
equal(textarea.selectionStart, 16, 'it should start highlighting at the right position'); equal(textarea.selectionStart, 24, 'it should start highlighting at the right position');
equal(textarea.selectionEnd, 36, 'it should end highlighting at the right position'); equal(textarea.selectionEnd, 44, 'it should end highlighting at the right position');
}); });
fillIn('.d-editor-input', "Before\nsome text in between\nAfter"); fillIn('.d-editor-input', "Before\nsome text in between\nAfter");
@ -85,12 +85,12 @@ test('details button', () => {
andThen(() => { andThen(() => {
equal( equal(
find(".d-editor-input").val(), find(".d-editor-input").val(),
`Before\n[details=some text in between]${I18n.t("composer.details_text")}[/details]\nAfter`, `Before\n[details=${I18n.t("composer.details_title")}]some text in between[/details]\nAfter`,
'it should contain the right output' 'it should contain the right output'
); );
const textarea = findTextarea(); const textarea = findTextarea();
equal(textarea.selectionStart, 16, 'it should start highlighting at the right position'); equal(textarea.selectionStart, 24, 'it should start highlighting at the right position');
equal(textarea.selectionEnd, 36, 'it should end highlighting at the right position'); equal(textarea.selectionEnd, 44, 'it should end highlighting at the right position');
}); });
}); });