From 5af2f4b888ab303803742f9228cd683c4c1536ff Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Tue, 6 Jun 2023 16:39:18 +0900 Subject: [PATCH] DEV: Skip flaky network disconnected test (#21945) Follow up to c574d7c5550cd5f955ca434e6443dee613bea2da. Skipping the entire file because both tests are flaky. --- spec/system/network_disconnected_spec.rb | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/spec/system/network_disconnected_spec.rb b/spec/system/network_disconnected_spec.rb index df658088a4d..4cd675cd725 100644 --- a/spec/system/network_disconnected_spec.rb +++ b/spec/system/network_disconnected_spec.rb @@ -3,13 +3,23 @@ RSpec.describe "Network Disconnected", type: :system, js: true do fab!(:current_user) { Fabricate(:user) } + before { skip(<<~TEXT) } + This group of tests is flaky and needs to be fixed. Example of error: + + Failures: + + 1) Network Disconnected Doesn't show the offline indicator when the site setting isn't present + Failure/Error: expect(page).to have_css("html.message-bus-offline") + expected to find css "html.message-bus-offline" but there were no matches + TEXT + def with_network_disconnected page.driver.browser.network_conditions = { offline: true } yield page.driver.browser.network_conditions = { offline: false } end - xit "Message bus connectivity service adds class to DOM and displays offline indicator" do + it "Message bus connectivity service adds class to DOM and displays offline indicator" do SiteSetting.enable_offline_indicator = true visit("/c")