DEV: Remove flaky test for now (#29249)

Adding the directory item test causes the default test to fail randomly due to directory items not getting removed properly.

Removing this for now, and also moving this test to the common system folder instead of system/user_page
This commit is contained in:
Natalie Tay 2024-10-17 16:58:35 +08:00 committed by GitHub
parent bfb5eaf21a
commit 5d657c8c41
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -1,7 +1,8 @@
# frozen_string_literal: true
describe "Users /u", type: :system do
describe "Users directory", type: :system do
fab!(:user)
let!(:initial_directory_events) { [] }
before { Array.new(DirectoryItemsController::PAGE_SIZE + 10) { Fabricate(:user) } }
@ -58,55 +59,4 @@ describe "Users /u", type: :system do
)
end
end
describe "new directory item" do
let!(:plugin) { Plugin::Instance.new }
let!(:initial_directory_events) { [] }
before do
initial_directory_events.replace(DiscourseEvent.events["before_directory_refresh"].to_a)
DB.exec("ALTER TABLE directory_items ADD COLUMN IF NOT EXISTS links integer")
end
after do
DiscourseEvent.events["before_directory_refresh"].delete(
(DiscourseEvent.events["before_directory_refresh"].to_a - initial_directory_events).last,
)
DB.exec("ALTER TABLE directory_items DROP COLUMN IF EXISTS links")
end
it "shows the directory column with the appropriate label" do
plugin.add_directory_column(
"links",
query: "SELECT id, RANDOM() AS random_number FROM users;",
)
DirectoryItem.refresh!
DirectoryColumn.find_by(name: "links").update!(enabled: true)
sign_in(user)
visit("/u")
expect(page).to have_css(".users-directory")
expect(page).not_to have_css(".spinner")
header_texts =
page
.all(".directory-table__column-header .header-contents")
.map { |element| element.text.strip }
expect(header_texts).to eq(
[
"Username",
"Received",
"Given",
"Topics Created",
"Replies Posted",
"Topics Viewed",
"Posts Read",
"Days Visited",
"Links",
],
)
end
end
end