github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-30 06:04:09 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Set the video background to be black (#25744)

Browse Source 
If you upload a portrait video or just a video that doesn't fit in the
normal video dimensions we want it to have a black background instead of
trying to render parts of the placeholder image as the video background.

This change removes the placeholder image for the video background when
the play button is clicked and replaces it with an all black background.
This commit is contained in:
Blake Erickson 2024-02-19 12:46:45 -07:00 committed by GitHub
parent a03b9f1602
commit 5ebe91a9a4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/discourse/app/instance-initializers/video-placeholder.js
View File

@ -67,6 +67,7 @@ export default {
wrapper.remove(); wrapper.remove();
video.style.display = ""; video.style.display = "";
parentDiv.classList.remove("video-placeholder-container"); parentDiv.classList.remove("video-placeholder-container");
parentDiv.style.backgroundImage = "none";
}); });
} }

1
app/assets/stylesheets/common/base/onebox.scss
View File

@ -927,6 +927,7 @@ aside.onebox.mixcloud-preview {
position: relative; position: relative;
padding: 0 0 56.25% 0; padding: 0 0 56.25% 0;
width: 100%; width: 100%;
background-color: black;
video { video {
position: absolute; position: absolute;