github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-31 08:28:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

PERF: Prefer joins over IN () queries.

Browse Source
This commit is contained in:
Guo Xiang Tan 2019-05-29 08:51:30 +08:00
parent 76569b2018
commit 63292cecd9
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/models/user_search.rb
View File

@ -23,9 +23,8 @@ class UserSearch
users = users.where(staged: false) unless @include_staged_users
if @group
users = users.where('users.id IN (
SELECT user_id FROM group_users WHERE group_id = ?
)', @group.id)
users = users.joins("INNER JOIN group_users ON group_users.user_id = users.id")
.where("group_users.group_id = ?", @group.id)
end
unless @searching_user && @searching_user.staff?