github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 09:42:07 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

FIX: category routes model params should decode their URL parts (#8612)

Browse Source 
* FIX: category routes model params should decode their URL parts

Ember's route star globbing does not uri decode by default. This is
problematic for subcategory globs with encoded URL site settings enabled.

Subcategories with encoded URLs will 404 without this decode.

I found this https://github.com/tildeio/route-recognizer/pull/91
which explicitly explains that globbing does not decode automatically.
This commit is contained in:
Jeff Wong 2019-12-23 10:24:41 -08:00 committed by GitHub
parent e36efb1edc
commit 63323bd7a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/discourse/models/category.js.es6
View File

@ -334,7 +334,11 @@ Category.reopenClass({
}, },
findBySlugPathWithID(slugPathWithID) { findBySlugPathWithID(slugPathWithID) {
const parts = slugPathWithID.split("/"); let parts = slugPathWithID.split("/");
// slugs found by star/glob pathing in emeber do not automatically url decode - ensure that these are decoded
if (Discourse.SiteSettings.slug_generation_method === "encoded") {
parts = parts.map(urlPart => decodeURI(urlPart));
}
let category = null; let category = null;
if (parts.length > 0 && parts[parts.length - 1].match(/^\d+$/)) { if (parts.length > 0 && parts[parts.length - 1].match(/^\d+$/)) {