github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-21 20:40:58 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Patch deprecated-run-loop-and-computed-dot-access in production (#25074)

Browse Source 
In Ember, these deprecations are wrapped in an `if(DEBUG)` check, so they are optimized out of the production build. We prefer to keep deprecations in production so that we can collect telemetry and warn theme authors who do not use local development environments.

This commit restores the deprecations as part of our ember-production-deprecations addon.
This commit is contained in:
David Taylor 2024-01-02 10:44:26 +00:00 committed by GitHub
parent b4f36507e0
commit 641c689ac1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 111 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.prettierignore
View File

@ -19,6 +19,7 @@ plugins/**/lib/javascripts/locale
public/
!/app/assets/javascripts/discourse/public
vendor/
!app/assets/javascripts/ember-production-deprecations/vendor/
app/assets/javascripts/discourse/tests/fixtures
spec/
node_modules/

111
app/assets/javascripts/ember-production-deprecations/vendor/ember-production-deprecations/deprecate-shim.js vendored
View File

@ -34,13 +34,15 @@ define("discourse/lib/deprecate-shim", ["exports"], function (exports) {
}
);
const deprecate = require("@ember/debug").deprecate;
// Patch ember-global deprecation
if (window.hasOwnProperty("Ember")) {
Object.defineProperty(window, "Ember", {
enumerable: true,
configurable: true,
get() {
require("@ember/debug").deprecate(
deprecate(
"Usage of the Ember Global is deprecated. You should import the Ember module or the specific API instead.",
false,
{
@ -58,6 +60,113 @@ define("discourse/lib/deprecate-shim", ["exports"], function (exports) {
},
});
}
// Patch run.blah deprecations
// https://github.com/emberjs/ember.js/blob/007fc9eba1/packages/%40ember/runloop/index.js#L748-L808
const deprecatedRunloopFunctions = [
"backburner",
"begin",
"bind",
"cancel",
"debounce",
"end",
"hasScheduledTimers",
"join",
"later",
"next",
"once",
"schedule",
"scheduleOnce",
"throttle",
"cancelTimers",
];
const run = require("@ember/runloop").run;
for (const name of deprecatedRunloopFunctions) {
const currentDescriptor = Object.getOwnPropertyDescriptor(run, name);
if (currentDescriptor?.value) {
Object.defineProperty(run, name, {
get() {
deprecate(
`Using \`run.${name}\` has been deprecated. Instead, import the value directly.`,
false,
{
id: "deprecated-run-loop-and-computed-dot-access",
until: "4.0.0",
for: "ember-source",
since: {
enabled: "3.27.0",
},
url: "https://deprecations.emberjs.com/v3.x/#toc_deprecated-run-loop-and-computed-dot-access",
}
);
return currentDescriptor.value;
},
});
}
}
// Patch computed.blah deprecations
// https://github.com/emberjs/ember.js/blob/v3.28.12/packages/%40ember/object/index.js#L60-L118
const deprecatedComputedFunctions = [
"alias",
"and",
"bool",
"collect",
"deprecatingAlias",
"empty",
"equal",
"filterBy",
"filter",
"gte",
"gt",
"intersect",
"lte",
"lt",
"mapBy",
"map",
"match",
"max",
"min",
"none",
"notEmpty",
"not",
"oneWay",
"reads",
"or",
"readOnly",
"setDiff",
"sort",
"sum",
"union",
"uniqBy",
"uniq",
];
const computed = require("@ember/object").computed;
for (const name of deprecatedComputedFunctions) {
const currentDescriptor = Object.getOwnPropertyDescriptor(computed, name);
if (currentDescriptor?.value) {
Object.defineProperty(computed, name, {
get() {
deprecate(
`Using \`computed.${name}\` has been deprecated. Instead, import the value directly.`,
false,
{
id: "deprecated-run-loop-and-computed-dot-access",
until: "4.0.0",
for: "ember-source",
since: {
enabled: "3.27.0",
},
url: "https://deprecations.emberjs.com/v3.x/#toc_deprecated-run-loop-and-computed-dot-access",
}
);
return currentDescriptor.value;
},
});
}
}
};
});