github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 01:45:05 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Do not dump schema during production database migrations (#12785)

Browse Source 
It's important that we don't perform pg_dumps against databases
running behind pgbouncer.

We had an old monkey-patch to prevent this, but following some [recent
internal rails refactoring](5488686851),
the patch no longer works. Instead, we can use the official
`config.active_record.dump_schema_after_migration` option.

Setting this to false in production is recommended by Rails, and is the
default for newly generated Rails applications.
This commit is contained in:
David Taylor 2021-04-21 16:26:20 +01:00 committed by GitHub
parent e4f1760bab
commit 65164bf189
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Rakefile
View File

@ -7,7 +7,3 @@
require File.expand_path('../config/application', __FILE__) require File.expand_path('../config/application', __FILE__)
Discourse::Application.load_tasks Discourse::Application.load_tasks
# this prevents crashes when migrating a database in production in certain
# PostgreSQL configuations when trying to create structure.sql
Rake::Task["db:structure:dump"].clear if Rails.env.production?

1
config/environments/production.rb
View File

@ -67,4 +67,5 @@ Discourse::Application.configure do
config.developer_emails = emails.split(",").map(&:downcase).map(&:strip) config.developer_emails = emails.split(",").map(&:downcase).map(&:strip)
end end
config.active_record.dump_schema_after_migration = false
end end