github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 12:40:40 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: prevents body scroll to hide sticky elements (#26400)

Browse Source 
Applying `overflow: hidden` was not playing well with sticky elements (like the header for example). It appears that we don't really need this to achieve our goal so Im removing this part of body scroll lock for now.
This commit is contained in:
Joffrey JAFFEUX 2024-03-27 15:21:19 +01:00 committed by GitHub
parent fd83107674
commit 65c03af919
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
app/assets/javascripts/discourse/app/lib/body-scroll-lock.js
View File

@ -45,7 +45,6 @@ let locks = [];
let locksIndex = /* @__PURE__ */ new Map();
let documentListenerAdded = false;
let initialClientY = -1;
let previousBodyOverflowSetting;
let htmlStyle;
let bodyStyle;
let previousBodyPaddingRight;
@ -89,20 +88,12 @@ const setOverflowHidden = (options) => {
}px`;
}
}
if (previousBodyOverflowSetting === void 0) {
previousBodyOverflowSetting = document.body.style.overflow;
document.body.style.overflow = "hidden";
}
};
const restoreOverflowSetting = () => {
if (previousBodyPaddingRight !== void 0) {
document.body.style.paddingRight = previousBodyPaddingRight;
previousBodyPaddingRight = void 0;
}
if (previousBodyOverflowSetting !== void 0) {
document.body.style.overflow = previousBodyOverflowSetting;
previousBodyOverflowSetting = void 0;
}
};
const setPositionFixed = () =>
window.requestAnimationFrame(() => {
@ -119,17 +110,6 @@ const setPositionFixed = () =>
$body.style.left = `${-scrollX}px`;
$body.style.width = "100%";
$body.style.height = "auto";
$body.style.overflow = "hidden";
setTimeout(
() =>
window.requestAnimationFrame(() => {
const bottomBarHeight = innerHeight - window.innerHeight;
if (bottomBarHeight && scrollY >= innerHeight) {
$body.style.top = -(scrollY + bottomBarHeight) + "px";
}
}),
300
);
}
});
const restorePositionSetting = () => {