github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-05 03:00:29 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove harded id when fabricating in tests (#18729) (#18730)

Browse Source 
Hardcoding ids always lead to sadness for our test suite
This commit is contained in:
Alan Guo Xiang Tan 2022-10-25 06:33:36 +08:00 committed by GitHub
parent 6c97cc1834
commit 689ba22db0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spec/components/topic_view_spec.rb
View File

@ -996,7 +996,7 @@ RSpec.describe TopicView do
subject(:topic_view) { described_class.new(topic, user) } subject(:topic_view) { described_class.new(topic, user) }
let(:topic) { Fabricate(:topic) } let(:topic) { Fabricate(:topic) }
let(:user) { Fabricate(:user, id: 1) } let(:user) { Fabricate(:user) }
let(:category) { topic.category } let(:category) { topic.category }
before do before do

2
spec/serializers/post_serializer_spec.rb
View File

@ -107,7 +107,7 @@ describe PostSerializer do
end end
context "with a hidden post with add_raw enabled" do context "with a hidden post with add_raw enabled" do
let(:user) { Fabricate(:user, id: -99999) } let(:user) { Fabricate(:user) }
let(:raw) { "Raw contents of the post." } let(:raw) { "Raw contents of the post." }
context "with a public post" do context "with a public post" do