github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 02:50:00 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: nil emails are invalid

Browse Source
This commit is contained in:
Sam 2015-05-27 14:12:10 +10:00
parent 02fa7448ca
commit 693b5234da
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/email.rb
View File

@ -7,6 +7,9 @@ require_dependency 'email/styles'
module Email module Email
def self.is_valid?(email) def self.is_valid?(email)
return false unless String === email
parser = Mail::RFC2822Parser.new parser = Mail::RFC2822Parser.new
parser.root = :addr_spec parser.root = :addr_spec
result = parser.parse(email) result = parser.parse(email)

4
spec/components/email/email_spec.rb
View File

@ -5,6 +5,10 @@ describe Email do
describe "is_valid?" do describe "is_valid?" do
it 'treats a nil as invalid' do
expect(Email.is_valid?(nil)).to eq(false)
end
it 'treats a good email as valid' do it 'treats a good email as valid' do
expect(Email.is_valid?('sam@sam.com')).to eq(true) expect(Email.is_valid?('sam@sam.com')).to eq(true)
end end