FIX: Defer removing the splash screen until the window load event fires (#17225)

There's an obscure bug where really slow devices end up removing the splash screen before they're finished parsing all of the Discourse assets.

This PR won't impact fast devices but should hopefully prevent the premature removal of the splash on super slow devices.
This commit is contained in:
Joe 2022-06-24 11:27:41 +08:00 committed by GitHub
parent 7b2ad1b931
commit 6a61e855b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -82,8 +82,14 @@ const Discourse = Application.extend({
});
});
// The app booted. Remove the splash screen
document.querySelector("#d-splash")?.remove();
window.addEventListener(
"load",
() => {
// The app booted. Remove the splash screen
document.querySelector("#d-splash")?.remove();
},
{ once: true }
);
},
_registerPluginCode(version, code) {