From 6d7dd658a470b7878d403f48bb6ab263a6d37af8 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Mon, 18 Dec 2023 13:44:36 +0100 Subject: [PATCH] DEV: Update rubocop-discourse to 3.6.0 (#24945) --- Gemfile.lock | 6 +++--- script/benchmarks/middleware/test.rb | 1 + script/import_scripts/google_groups.rb | 2 +- spec/system/page_objects/components/navigation_menu/base.rb | 4 ---- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 528e9790d00..dad1b99d7b5 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -424,9 +424,9 @@ GEM parser (>= 3.2.1.0) rubocop-capybara (2.19.0) rubocop (~> 1.41) - rubocop-discourse (3.4.1) - rubocop (>= 1.1.0) - rubocop-rspec (>= 2.0.0) + rubocop-discourse (3.6.0) + rubocop (>= 1.59.0) + rubocop-rspec (>= 2.25.0) rubocop-factory_bot (2.24.0) rubocop (~> 1.33) rubocop-rspec (2.25.0) diff --git a/script/benchmarks/middleware/test.rb b/script/benchmarks/middleware/test.rb index 8b0cca5f6ea..9423136b6b9 100644 --- a/script/benchmarks/middleware/test.rb +++ b/script/benchmarks/middleware/test.rb @@ -1,4 +1,5 @@ # frozen_string_literal: true +# rubocop:disable Lint/UnreachableCode require "memory_profiler" require "benchmark/ips" diff --git a/script/import_scripts/google_groups.rb b/script/import_scripts/google_groups.rb index 3f04bec872d..d6a095f5091 100755 --- a/script/import_scripts/google_groups.rb +++ b/script/import_scripts/google_groups.rb @@ -105,7 +105,7 @@ def crawl_topics # abort if this in an incremental crawl and there were too many consecutive, skipped topics if @finished && @skipped_topic_count > ABORT_AFTER_SKIPPED_TOPIC_COUNT puts "Skipping all other topics, because this is an incremental crawl.".green - return + return # rubocop:disable Lint/NonLocalExitFromIterator end end end diff --git a/spec/system/page_objects/components/navigation_menu/base.rb b/spec/system/page_objects/components/navigation_menu/base.rb index 2d36514bbc5..890af45926b 100644 --- a/spec/system/page_objects/components/navigation_menu/base.rb +++ b/spec/system/page_objects/components/navigation_menu/base.rb @@ -60,10 +60,6 @@ module PageObjects find(".sidebar__panel-switch-button[data-key='main']").click end - def has_no_section?(name) - has_no_css?(".sidebar-sections [data-section-name='#{name.parameterize}']") - end - def has_switch_button?(key = nil) if key page.has_css?(".sidebar__panel-switch-button[data-key='#{key.parameterize}']")