From 6e004b04e18330ac5c0d05e4ccc9307cede53e56 Mon Sep 17 00:00:00 2001 From: David Taylor Date: Thu, 12 Oct 2023 11:03:44 +0100 Subject: [PATCH] FIX: Support PluginOutlet invocations with deprecated tagName (#23913) This regressed in af305366 --- .../discourse/app/components/plugin-outlet.js | 2 +- .../integration/components/plugin-outlet-test.gjs | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/app/components/plugin-outlet.js b/app/assets/javascripts/discourse/app/components/plugin-outlet.js index 7135f27c7a2..05f2a6d8295 100644 --- a/app/assets/javascripts/discourse/app/components/plugin-outlet.js +++ b/app/assets/javascripts/discourse/app/components/plugin-outlet.js @@ -83,7 +83,7 @@ export default class PluginOutletComponent extends GlimmerComponentWithDeprecate } @bind - getConnectors({ hasBlock }) { + getConnectors({ hasBlock } = {}) { const connectors = renderedConnectorsFor( this.args.name, this.outletArgsWithDeprecations, diff --git a/app/assets/javascripts/discourse/tests/integration/components/plugin-outlet-test.gjs b/app/assets/javascripts/discourse/tests/integration/components/plugin-outlet-test.gjs index f27599695ca..72f143b2b66 100644 --- a/app/assets/javascripts/discourse/tests/integration/components/plugin-outlet-test.gjs +++ b/app/assets/javascripts/discourse/tests/integration/components/plugin-outlet-test.gjs @@ -460,3 +460,16 @@ module( }); } ); + +module("Integration | Component | plugin-outlet | tagName", function (hooks) { + setupRenderingTest(hooks); + + test("supports the `@tagName` argument", async function (assert) { + await withSilencedDeprecationsAsync( + "discourse.plugin-outlet-tag-name", + async () => + await render(hbs``) + ); + assert.dom("div").exists(); + }); +});