Drop tif, tiff, webp and bmp from supported images.

https://meta.discourse.org/t/cr2-raw-files-are-being-treated-as-tiff-files/96775/3?u=tgxworld
This commit is contained in:
Guo Xiang Tan 2018-09-10 10:49:01 +08:00
parent e1b16e445e
commit 71caf7521d
3 changed files with 22 additions and 1 deletions

View File

@ -101,7 +101,7 @@ class FileHelper
end
def self.supported_images
@@supported_images ||= Set.new %w{jpg jpeg png gif tif tiff bmp svg webp ico}
@@supported_images ||= Set.new %w{jpg jpeg png gif svg ico}
end
def self.supported_images_regexp

BIN
spec/fixtures/images/webp_as.bin vendored Normal file

Binary file not shown.

After

Width:  |  Height:  |  Size: 26 B

View File

@ -43,6 +43,27 @@ RSpec.describe UploadCreator do
expect(File.extname(upload.url)).to eq('.png')
expect(upload.original_filename).to eq('png_as.png')
end
describe 'for webp format' do
before do
SiteSetting.authorized_extensions = '.webp|.bin'
end
let(:filename) { "webp_as.bin" }
let(:file) { file_from_fixtures(filename) }
it 'should not correct the coerce filename' do
expect do
UploadCreator.new(file, filename).create_for(user.id)
end.to change { Upload.count }.by(1)
upload = Upload.last
expect(upload.extension).to eq('bin')
expect(File.extname(upload.url)).to eq('.bin')
expect(upload.original_filename).to eq('webp_as.bin')
end
end
end
describe 'converting to jpeg' do