github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 02:19:27 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Add missing report filter type in bookmarks report (#22616)

Browse Source 
Adding a filter without a type parameter has been deprecated for the last three years, and was marked for removal in 2.9.0.

During this time we have had a few deprecation warnings in logs coming from Reports::Bookmarks.

The fallback was to set the type to the name of the filter. This change just passes the type (same as name) explicitly instead, and removes the deprecation fallback.
This commit is contained in:
Ted Johansson 2023-07-18 11:07:01 +08:00 committed by GitHub
parent 1cb2043edc
commit 72ea73988c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/concerns/reports/bookmarks.rb
View File

@ -8,7 +8,7 @@ module Reports::Bookmarks
report.icon = "bookmark"
category_filter = report.filters.dig(:category)
report.add_filter("category", default: category_filter)
report.add_filter("category", type: "category", default: category_filter)
report.data = []
Bookmark

8
app/models/report.rb
View File

@ -129,14 +129,6 @@ class Report
end
def add_filter(name, options = {})
if options[:type].blank?
options[:type] = name
Discourse.deprecate(
"#{name} filter should define a `:type` option. Temporarily setting type to #{name}.",
drop_from: "2.9.0",
)
end
available_filters[name] = options
end