github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 14:49:07 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Disallow moderators from custom public sidebar sections (#23683)

Browse Source 
Currently moderators can see the custom public sidebar section edit button, but they are prevented from making any changes by an error. According to the back-end, moderators can not access these.

This PR hides the custom public sidebar section edit button, as well as the "make public" checkbox of the create modal, if the user is not an admin, bringing the UI in line with the back-end.

If needed, we can add a site setting to allow moderator access when the need arises.
This commit is contained in:
Ted Johansson 2023-09-27 19:52:23 +02:00 committed by GitHub
parent ca394177cb
commit 7569b64362
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/components/modal/sidebar-section-form.hbs
View File

@ -83,7 +83,7 @@
/>
{{/if}}
{{#if (and this.currentUser.staff)}}
{{#if (and this.currentUser.admin)}}
<div
class="row-wrapper mark-public-wrapper
{{if this.transformedModel.sectionType '-disabled'}}"

2
app/assets/javascripts/discourse/app/lib/sidebar/section.js
View File

@ -37,7 +37,7 @@ export default class Section {
}
get headerActions() {
if (!this.section.public || this.currentUser?.staff) {
if (!this.section.public || this.currentUser?.admin) {
return [
{
action: () => {