github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-16 05:23:48 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

SECURITY: XSS issue in share popup if invalid link is passed in.

Browse Source
This commit is contained in:
Guo Xiang Tan 2017-05-04 10:33:59 +08:00 committed by Robin Ward
parent d143cde643
commit 790acfd99f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/components/share-popup.js.es6
View File

@ -39,7 +39,7 @@ export default Ember.Component.extend({
} else { } else {
const $linkForTouch = $('#share-link .share-for-touch a'); const $linkForTouch = $('#share-link .share-for-touch a');
$linkForTouch.attr('href', link); $linkForTouch.attr('href', link);
$linkForTouch.html(link); $linkForTouch.text(link);
const range = window.document.createRange(); const range = window.document.createRange();
range.selectNode($linkForTouch[0]); range.selectNode($linkForTouch[0]);
window.getSelection().addRange(range); window.getSelection().addRange(range);