mirror of
https://github.com/discourse/discourse.git
synced 2024-11-22 11:44:49 +08:00
DEV: Auto grid images no longer experimental (#29572)
Some checks are pending
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Some checks are pending
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Recently we added a new feature for automatically gridding images in the composer (https://github.com/discourse/discourse/pull/29260). After testing this feature under a setting for a short period of time, the feature is no longer experimental anymore. This PR removes the site setting `experimental_auto_grid_images`.
This commit is contained in:
parent
1d637c5243
commit
7a936da05c
|
@ -352,10 +352,7 @@ export default class UppyComposerUpload {
|
||||||
});
|
});
|
||||||
|
|
||||||
const MIN_IMAGES_TO_AUTO_GRID = 3;
|
const MIN_IMAGES_TO_AUTO_GRID = 3;
|
||||||
if (
|
if (this.#consecutiveImages?.length >= MIN_IMAGES_TO_AUTO_GRID) {
|
||||||
this.siteSettings.experimental_auto_grid_images &&
|
|
||||||
this.#consecutiveImages?.length >= MIN_IMAGES_TO_AUTO_GRID
|
|
||||||
) {
|
|
||||||
this.#autoGridImages();
|
this.#autoGridImages();
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
|
@ -2728,7 +2728,6 @@ en:
|
||||||
experimental_form_templates: "EXPERIMENTAL: Enable the form templates feature. <b>After enabled,</b> manage the templates at <a href='%{base_path}/admin/customize/form-templates'>Customize / Templates</a>."
|
experimental_form_templates: "EXPERIMENTAL: Enable the form templates feature. <b>After enabled,</b> manage the templates at <a href='%{base_path}/admin/customize/form-templates'>Customize / Templates</a>."
|
||||||
admin_sidebar_enabled_groups: "Enable sidebar navigation for the admin UI for the specified groups, which replaces the top-level admin navigation buttons."
|
admin_sidebar_enabled_groups: "Enable sidebar navigation for the admin UI for the specified groups, which replaces the top-level admin navigation buttons."
|
||||||
lazy_load_categories_groups: "EXPERIMENTAL: Lazy load category information only for users of these groups. This improves performance on sites with many categories."
|
lazy_load_categories_groups: "EXPERIMENTAL: Lazy load category information only for users of these groups. This improves performance on sites with many categories."
|
||||||
experimental_auto_grid_images: "EXPERIMENTAL: Automatically wraps images in [grid] tags when 3 or more images are uploaded in the composer."
|
|
||||||
|
|
||||||
page_loading_indicator: "Configure the loading indicator which appears during page navigations within Discourse. 'Spinner' is a full page indicator. 'Slider' shows a narrow bar at the top of the screen."
|
page_loading_indicator: "Configure the loading indicator which appears during page navigations within Discourse. 'Spinner' is a full page indicator. 'Slider' shows a narrow bar at the top of the screen."
|
||||||
show_user_menu_avatars: "Show user avatars in the user menu"
|
show_user_menu_avatars: "Show user avatars in the user menu"
|
||||||
|
|
|
@ -2471,9 +2471,6 @@ developer:
|
||||||
default: 50
|
default: 50
|
||||||
hidden: true
|
hidden: true
|
||||||
client: true
|
client: true
|
||||||
experimental_auto_grid_images:
|
|
||||||
default: false
|
|
||||||
client: true
|
|
||||||
|
|
||||||
navigation:
|
navigation:
|
||||||
navigation_menu:
|
navigation_menu:
|
||||||
|
|
|
@ -160,8 +160,6 @@ describe "Uploading files in the composer", type: :system do
|
||||||
end
|
end
|
||||||
|
|
||||||
context "when multiple images are uploaded" do
|
context "when multiple images are uploaded" do
|
||||||
before { SiteSetting.experimental_auto_grid_images = true }
|
|
||||||
|
|
||||||
it "automatically wraps images in [grid] tags on 3 or more images" do
|
it "automatically wraps images in [grid] tags on 3 or more images" do
|
||||||
visit "/new-topic"
|
visit "/new-topic"
|
||||||
expect(composer).to be_opened
|
expect(composer).to be_opened
|
||||||
|
@ -227,8 +225,6 @@ describe "Uploading files in the composer", type: :system do
|
||||||
end
|
end
|
||||||
|
|
||||||
it "does not automatically wrap images in [grid] tags when setting is disabled" do
|
it "does not automatically wrap images in [grid] tags when setting is disabled" do
|
||||||
SiteSetting.experimental_auto_grid_images = false
|
|
||||||
|
|
||||||
visit "/new-topic"
|
visit "/new-topic"
|
||||||
expect(composer).to be_opened
|
expect(composer).to be_opened
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue
Block a user