From 7c057878e2902ccdafd6a4a5df3120144c42f3ac Mon Sep 17 00:00:00 2001
From: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Date: Sun, 22 Oct 2023 18:50:04 +0200
Subject: [PATCH] DEV: skips two flakey specs (#24044)
---
plugins/chat/spec/system/channel_members_page_spec.rb | 9 ++-------
plugins/chat/spec/system/navigation_spec.rb | 2 +-
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/plugins/chat/spec/system/channel_members_page_spec.rb b/plugins/chat/spec/system/channel_members_page_spec.rb
index 92dc9a6a4f6..c3b411aabb3 100644
--- a/plugins/chat/spec/system/channel_members_page_spec.rb
+++ b/plugins/chat/spec/system/channel_members_page_spec.rb
@@ -35,13 +35,12 @@ RSpec.describe "Channel - Info - Members page", type: :system do
channel_1.add(current_user)
channel_1.add(Fabricate(:user, username: "cat"))
98.times { channel_1.add(Fabricate(:user)) }
- end
-
- it "shows all members" do
Jobs.run_immediately!
channel_1.update!(user_count_stale: true)
Jobs::Chat::UpdateChannelUserCount.new.execute(chat_channel_id: channel_1.id)
+ end
+ xit "shows all members" do
chat_page.visit_channel_members(channel_1)
expect(page).to have_selector(".chat-channel-members__list-item", count: 60)
@@ -57,10 +56,6 @@ RSpec.describe "Channel - Info - Members page", type: :system do
context "with filter" do
it "filters members" do
- Jobs.run_immediately!
- channel_1.update!(user_count_stale: true)
- Jobs::Chat::UpdateChannelUserCount.new.execute(chat_channel_id: channel_1.id)
-
chat_page.visit_channel_members(channel_1)
find(".chat-channel-members__filter").fill_in(with: "cat")
diff --git a/plugins/chat/spec/system/navigation_spec.rb b/plugins/chat/spec/system/navigation_spec.rb
index b80cd4fe881..80ce444c155 100644
--- a/plugins/chat/spec/system/navigation_spec.rb
+++ b/plugins/chat/spec/system/navigation_spec.rb
@@ -131,7 +131,7 @@ RSpec.describe "Navigation", type: :system do
end
context "when opening a thread from the thread list" do
- it "goes back to the thread list when clicking the back button" do
+ xit "goes back to the thread list when clicking the back button" do
skip("Flaky on CI") if ENV["CI"]
visit("/chat")