github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 13:09:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Enable the normalize_emails site setting by default (#29587)

Browse Source 
The normalize_emails setting makes it so that only canonical e-mails are considered for validation purposes. This means disallowing "plus addressing". For example, with this enabled, bob@discourse.org and bob+foo@discourse.org are considered the same address, and you can only sign up with one of them.

Currently this is disabled by default, leading to a lot of spam sign-ups. It's healthier to consider this an opt-out setting.
This commit is contained in:
Ted Johansson 2024-11-06 11:20:36 +08:00 committed by GitHub
parent 973b599e11
commit 7d9d98422c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config/site_settings.yml
View File

@ -596,7 +596,7 @@ login:
type: host_list
list_type: simple
normalize_emails:
default: false
default: true
auto_approve_email_domains:
default: ""
type: host_list

8
spec/lib/search_spec.rb
View File

@ -804,11 +804,11 @@ RSpec.describe Search do
end
context "with all topics" do
let!(:u1) { Fabricate(:user, username: "fred", name: "bob jones", email: "foo+1@bar.baz") }
let!(:u2) { Fabricate(:user, username: "bob", name: "fred jones", email: "foo+2@bar.baz") }
let!(:u3) { Fabricate(:user, username: "jones", name: "bob fred", email: "foo+3@bar.baz") }
let!(:u1) { Fabricate(:user, username: "fred", name: "bob jones", email: "fred@bar.baz") }
let!(:u2) { Fabricate(:user, username: "bob", name: "fred jones", email: "bob@bar.baz") }
let!(:u3) { Fabricate(:user, username: "jones", name: "bob fred", email: "jones@bar.baz") }
let!(:u4) do
Fabricate(:user, username: "alice", name: "bob fred", email: "foo+4@bar.baz", admin: true)
Fabricate(:user, username: "alice", name: "bob fred", email: "alice@bar.baz", admin: true)
end
let!(:public_topic) { Fabricate(:topic, user: u1) }

2
spec/models/discourse_connect_spec.rb
View File

@ -904,7 +904,7 @@ RSpec.describe DiscourseConnect do
user = sso.lookup_or_create_user(ip_address)
expect(user.active).to eq(true)
user.primary_email.update_columns(email: "xXx@themovie.com")
user.primary_email.update(email: "xXx@themovie.com")
user = sso.lookup_or_create_user(ip_address)
expect(user.email).to eq(old_email)