github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 08:09:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Fix system test assertion to avoid stale element reference error (#21944)

Browse Source 
What is this change required?

We were seeing this error on CI

```
  1) Fast edit when editing text that has strange characters saves when paragraph contains apostrophe
     Failure/Error:
       expect(find("#{topic_page.post_by_number_selector(2)} .cooked p")).to have_content(
         "It ‘twas a great’ “day”!",
       )

     Selenium::WebDriver::Error::StaleElementReferenceError:
       stale element reference: stale element not found
         (Session info: chrome=114.0.5735.90)
```

I believe this is because the element that is "found" using `find` is
eventually re-rendered before the `have_content` matcher is called on
it.
This commit is contained in:
Alan Guo Xiang Tan 2023-06-06 16:43:49 +09:00 committed by GitHub
parent 5af2f4b888
commit 7ef2eaa892
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
spec/system/fast_edit_spec.rb
View File

@ -47,8 +47,9 @@ describe "Fast edit", type: :system, js: true do
fast_editor.fill_content("day")
fast_editor.save
expect(find("#{topic_page.post_by_number_selector(2)} .cooked p")).to have_content(
"It ‘twas a great’ “day”!",
expect(page).to have_selector(
"#{topic_page.post_by_number_selector(2)} .cooked p",
text: "It ‘twas a great’ “day”!",
)
end
end