github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 09:42:07 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

UX: Mark pre-populated dropdowns as not required (#19064)

Browse Source 
These two dropdown fields in the setup wizard are pre-populated, and
there is no way to de-select a value, you can only change it. So we can
remove the required attribute so that an asterisk doesn't show up in the
UI.
This commit is contained in:
Blake Erickson 2022-11-16 14:53:45 -07:00 committed by GitHub
parent 33816bbaa9
commit 7f63e72a50
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/wizard/builder.rb
View File

@ -19,7 +19,7 @@ class Wizard
languages = step.add_field(id: 'default_locale',
type: 'dropdown',
required: true,
required: false,
value: SiteSetting.default_locale)
LocaleSiteSetting.values.each do |locale|
@ -129,7 +129,7 @@ class Wizard
end
current = SiteSetting.top_menu.starts_with?("categories") ? SiteSetting.desktop_category_page_style : "latest"
style = step.add_field(id: 'homepage_style', type: 'dropdown', required: true, value: current, show_in_sidebar: true)
style = step.add_field(id: 'homepage_style', type: 'dropdown', required: false, value: current, show_in_sidebar: true)
style.add_choice('latest')
CategoryPageStyle.values.each do |page|
style.add_choice(page[:value])