github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 20:02:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Destroy application instance after each test (#14455)

Browse Source 
Under Ember CLI, we create a new application instance for each test. We were not correctly destroying it after the test, causing many references to be maintaned (e.g. at the end of a test run, `Ember.Namespace.NAMESPACES` would have an entry for each application instance).

Calling `destroy` on the application instance tidies up these references, and is one step towards fixing our test memory leak problem. Unfortunately there still seem to be other references being held to the application, so this commit is not a total fix.
This commit is contained in:
David Taylor 2021-09-28 11:37:40 +01:00 committed by GitHub
parent 9d5da2b383
commit 7fa2eb52f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/discourse/tests/setup-tests.js
View File

@ -31,6 +31,7 @@ import { flushMap } from "discourse/models/store";
import { registerObjects } from "discourse/pre-initializers/inject-discourse-objects";
import { setupApplicationTest } from "ember-qunit";
import sinon from "sinon";
import { run } from "@ember/runloop";
const Plugin = $.fn.modal;
const Modal = Plugin.Constructor;
@ -63,6 +64,10 @@ let app;
let started = false;
function createApplication(config, settings) {
if (app) {
run(app, "destroy");
}
app = Application.create(config);
setApplication(app);
setResolver(buildResolver("discourse").create({ namespace: app }));