github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-18 13:03:16 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove assertion causing flaky test (#26075)

Browse Source 
Why this change?

Assertions against the database in a system test is not reliable because
the request sent from the client side may not have been processed when
the query to the database has been run.

The test was added to prevent a regression for 63119144ff
but it turns out that the test will still prevent the regression even if
we do not assert against the state in the database.
This commit is contained in:
Alan Guo Xiang Tan 2024-03-07 15:18:48 +08:00 committed by GitHub
parent b36256f222
commit 8029bc1dcd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spec/system/admin_customize_themes_spec.rb
View File

@ -69,8 +69,6 @@ describe "Admin Customize Themes", type: :system do
expect(color_scheme_settings.find(".setting-value")).to have_content(color_scheme.name) expect(color_scheme_settings.find(".setting-value")).to have_content(color_scheme.name)
expect(color_scheme_settings).not_to have_css(".submit-edit") expect(color_scheme_settings).not_to have_css(".submit-edit")
expect(color_scheme_settings).not_to have_css(".cancel-edit") expect(color_scheme_settings).not_to have_css(".cancel-edit")
expect(theme.reload.color_scheme_id).to eq(color_scheme.id)
end end
end end