From 85d4370f791a2e6e17a50cd9ab5de44cd1fcc0d2 Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Tue, 14 Jul 2020 17:05:01 +1000 Subject: [PATCH] DEV: pin the rotp gem Not ready for an upgrade due to: https://github.com/mdp/rotp/issues/98 The policy here is that for cases like this we pin the version and add a comment explaining why it is pinned. We can revisit in a few months depending on upstream. --- Gemfile | 4 +++- Gemfile.lock | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Gemfile b/Gemfile index 3dfe93145f5..f4ddfbb58f1 100644 --- a/Gemfile +++ b/Gemfile @@ -224,7 +224,9 @@ gem 'logster' gem 'sassc', '2.0.1', require: false gem "sassc-rails" -gem 'rotp', require: false +# see: https://github.com/mdp/rotp/issues/98 +gem 'rotp', '5.1.0' , require: false + gem 'rqrcode' gem 'rubyzip', require: false diff --git a/Gemfile.lock b/Gemfile.lock index 36c7c27712a..6cb9700c09e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -532,7 +532,7 @@ DEPENDENCIES redis redis-namespace rinku - rotp + rotp (= 5.1.0) rqrcode rspec rspec-html-matchers